Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic wasm compat #8

Draft
wants to merge 9 commits into
base: iroh-0.10.x
Choose a base branch
from
Draft

basic wasm compat #8

wants to merge 9 commits into from

Conversation

dignifiedquire
Copy link

No description provided.

@dignifiedquire dignifiedquire marked this pull request as draft May 22, 2024 10:32
@matheus23
Copy link

@dignifiedquire what's your reasoning for cfg-gating on both target_family = "wasm" and feature = "wasm"?

IMO I'd prefer only gating on target_family = "wasm".

@matheus23
Copy link

Ah I guess it makes sense to have a feature for browser-specific wasm code.
Maybe makes sense to bikeshed the name eventually.

@dignifiedquire
Copy link
Author

Ah I guess it makes sense to have a feature for browser-specific wasm code.
Maybe makes sense to bikeshed the name eventually.

Don't read too much into the current setup, ideally we can drop as much any feature usage, and do only target_familly where we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants