Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FFmpeg.cs #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed FFmpeg.cs #131

wants to merge 1 commit into from

Conversation

H41Ri0
Copy link

@H41Ri0 H41Ri0 commented Jun 3, 2022

Fixed a bug that prevented ffmpeg from exiting with subtitled mkv files

Fixed a bug that prevented ffmpeg from exiting with subtitled mkv files
@n00mkrad
Copy link
Owner

n00mkrad commented Jun 3, 2022

Seems like a bad idea, this will kill ALL running ffmpeg instances on the current users.

Can you show me how to reproduce this issue?

@H41Ri0
Copy link
Author

H41Ri0 commented Jun 3, 2022

Indeed. You are right.
This occurred with an mkv file with the following configuration
log.txt
Upscaling a file with this configuration will cause Cupscale.exe to stop working because ffmpeg will not exit. (Terminating ffmpeg in the Task Manager will restart the operation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants