-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JGit cannot find org.slf4j.impl.StaticLoggerBinder due to relocation #203
Comments
@n0mer could you please exclude slf4j from the relocation process to make the plugin use Gradle's logging infrastructure? |
@remal Semyon can you submit PR for this feature request , with test cases |
Is there anything that I can do to speed up resolving this issue ? I understand if the PR I proposed (especially regarding the integration testing) is not ready for a merge as is, I'd be happy to work with the maintainers here to get this or a similar fix merged. |
Can you please help to test v2.4.1? Thanks |
I confirm it works fine now, thanks! |
Can confirm this properly works on my end as well :) Thank you for the quick merge 👍 |
The gradle git properties plugin relocates the entire grgit library to a prefixed
gradlegitproperties
package.Due to the nature of the shadow plugin, the
slf4j-api
included byjgit
also has its import fororg.slf4j.impl.StaticLoggerBinder
relocated togradlegitproperties.org.slf4j.impl.StaticLoggerBinder
. As a result of this, the plugin does not find the gradle logging implementation when running, causing the rather unfortunate error message:The text was updated successfully, but these errors were encountered: