Exclude slf4j-api from grgit #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
force-pushed
the
bugfix/exclude-sfl4j-api
branch
2 times, most recently
from
52565e3 to
e831e2f
Compare
To prevent the plugin from shipping its own slf4j-api jar, which is improperly relocated and hence fails to bind to the gradle provided sfl4j implementation, this commit excludes the slf4j-api from grgit. The commit additionally contains an integration test that tests the shadowed plugin jar to ensure slf4j can properly bind.
lynxplay
force-pushed
the
bugfix/exclude-sfl4j-api
branch
from
e831e2f to
0c76b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the plugin from shipping its own slf4j-api jar,
which is improperly relocated and hence fails to bind to the gradle
provided sfl4j implementation, this commit excludes the slf4j-api from
grgit.
The commit additionally contains an integration test that tests the
shadowed plugin jar to ensure slf4j can properly bind.
Resolves: #203