Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript commonjs module resolution with node16,nodenext #1466

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

🦋 Changeset detected

Latest commit: 8e5fde6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@envelop/core Patch
@envelop/apollo-datasources Patch
@envelop/apollo-federation Patch
@envelop/apollo-server-errors Patch
@envelop/apollo-tracing Patch
@envelop/auth0 Patch
@envelop/dataloader Patch
@envelop/depth-limit Patch
@envelop/disable-introspection Patch
@envelop/execute-subscription-event Patch
@envelop/extended-validation Patch
@envelop/filter-operation-type Patch
@envelop/fragment-arguments Patch
@envelop/generic-auth Patch
@envelop/graphql-jit Patch
@envelop/graphql-middleware Patch
@envelop/graphql-modules Patch
@envelop/live-query Patch
@envelop/newrelic Patch
@envelop/opentelemetry Patch
@envelop/operation-field-permissions Patch
@envelop/parser-cache Patch
@envelop/persisted-operations Patch
@envelop/preload-assets Patch
@envelop/prometheus Patch
@envelop/rate-limiter Patch
@envelop/resource-limitations Patch
@envelop/response-cache Patch
@envelop/response-cache-redis Patch
@envelop/sentry Patch
@envelop/statsd Patch
@envelop/validation-cache Patch
@envelop/testing Patch
@envelop/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
envelop ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 10:10AM (UTC)

@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/core@2.4.2-alpha-1eb54ef.0
@envelop/apollo-datasources@1.1.2-alpha-1eb54ef.0
@envelop/apollo-federation@2.4.2-alpha-1eb54ef.0
@envelop/apollo-server-errors@3.4.2-alpha-1eb54ef.0
@envelop/apollo-tracing@3.4.2-alpha-1eb54ef.0
@envelop/auth0@3.4.2-alpha-1eb54ef.0
@envelop/dataloader@3.4.2-alpha-1eb54ef.0
@envelop/depth-limit@1.6.2-alpha-1eb54ef.0
@envelop/disable-introspection@3.4.2-alpha-1eb54ef.0
@envelop/execute-subscription-event@2.4.2-alpha-1eb54ef.0
@envelop/extended-validation@1.7.2-alpha-1eb54ef.0
@envelop/filter-operation-type@3.4.2-alpha-1eb54ef.0
@envelop/fragment-arguments@3.4.2-alpha-1eb54ef.0
@envelop/generic-auth@4.3.2-alpha-1eb54ef.0
@envelop/graphql-jit@4.4.2-alpha-1eb54ef.0
@envelop/graphql-middleware@3.4.2-alpha-1eb54ef.0
@envelop/graphql-modules@3.4.2-alpha-1eb54ef.0
@envelop/live-query@4.0.1-alpha-1eb54ef.0
@envelop/newrelic@4.1.2-alpha-1eb54ef.0
@envelop/opentelemetry@3.4.2-alpha-1eb54ef.0
@envelop/operation-field-permissions@3.4.2-alpha-1eb54ef.0
@envelop/parser-cache@4.5.2-alpha-1eb54ef.0
@envelop/persisted-operations@4.4.2-alpha-1eb54ef.0
@envelop/preload-assets@3.4.2-alpha-1eb54ef.0
@envelop/prometheus@6.4.2-alpha-1eb54ef.0
@envelop/rate-limiter@3.4.2-alpha-1eb54ef.0
@envelop/resource-limitations@2.4.2-alpha-1eb54ef.0
@envelop/response-cache@3.0.2-alpha-1eb54ef.0
@envelop/response-cache-redis@1.0.2-alpha-1eb54ef.0
@envelop/sentry@3.6.3-alpha-1eb54ef.0
@envelop/statsd@2.4.2-alpha-1eb54ef.0
@envelop/validation-cache@4.5.2-alpha-1eb54ef.0
@envelop/testing@4.4.2-alpha-1eb54ef.0
@envelop/types@2.3.1-alpha-1eb54ef.0

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 603154      ✗ 0     
     data_received......................................: 2.3 GB  16 MB/s
     data_sent..........................................: 131 MB  875 kB/s
     envelop_init.......................................: avg=589ns    min=99ns     med=300ns   max=594.21µs p(90)=899ns   p(95)=2.19µs 
     ✓ { mode:envelop-cache-jit }.......................: avg=403ns    min=199ns    med=399ns   max=123.9µs  p(90)=599ns   p(95)=700ns  
     ✓ { mode:envelop-just-cache }......................: avg=330ns    min=99ns     med=300ns   max=50µs     p(90)=500ns   p(95)=699ns  
     ✓ { mode:graphql-js }..............................: avg=561ns    min=99ns     med=300ns   max=594.21µs p(90)=2.19µs  p(95)=2.39µs 
     ✓ { mode:prom-tracing }............................: avg=3µs      min=1.5µs    med=2.1µs   max=324.9µs  p(90)=5.5µs   p(95)=7.2µs  
     envelop_total......................................: avg=202.95µs min=0s       med=21.29µs max=14.97ms  p(90)=452.2µs p(95)=1.51ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=21.64µs  min=16µs     med=19.9µs  max=13.82ms  p(90)=26.4µs  p(95)=29.5µs 
     ✓ { mode:envelop-just-cache }......................: avg=182.45µs min=159.8µs  med=176.5µs max=10.06ms  p(90)=190.5µs p(95)=200.7µs
     ✓ { mode:graphql-js }..............................: avg=494.01µs min=402µs    med=446.6µs max=14.97ms  p(90)=487.6µs p(95)=532.6µs
     ✓ { mode:prom-tracing }............................: avg=1.67ms   min=1.46ms   med=1.54ms  max=13.15ms  p(90)=1.65ms  p(95)=2.77ms 
     event_loop_lag.....................................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=3.73µs   min=1.69µs   med=2.99µs  max=1.62ms   p(90)=5.7µs   p(95)=7.6µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=2.79µs   min=1.69µs   med=2.59µs  max=1.62ms   p(90)=3.7µs   p(95)=4.3µs  
     ✓ { mode:envelop-just-cache }......................: avg=3.13µs   min=2.29µs   med=2.99µs  max=573.51µs p(90)=3.6µs   p(95)=4.1µs  
     ✓ { mode:graphql-js }..............................: avg=5.45µs   min=3.49µs   med=4.6µs   max=761.71µs p(90)=8.19µs  p(95)=9.39µs 
     ✓ { mode:prom-tracing }............................: avg=7.87µs   min=6.5µs    med=7.5µs   max=282.8µs  p(90)=8.49µs  p(95)=9.79µs 
     graphql_execute....................................: avg=206.97µs min=8.39µs   med=160µs   max=14.31ms  p(90)=186.4µs p(95)=1.46ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=11.22µs  min=8.39µs   med=10.2µs  max=13.81ms  p(90)=12.59µs p(95)=14µs   
     ✓ { mode:envelop-just-cache }......................: avg=171.59µs min=150.5µs  med=166.3µs max=10.05ms  p(90)=177.5µs p(95)=186.9µs
     ✓ { mode:graphql-js }..............................: avg=189.01µs min=155.4µs  med=168.7µs max=14.31ms  p(90)=181.9µs p(95)=192.3µs
     ✓ { mode:prom-tracing }............................: avg=1.6ms    min=1.4ms    med=1.47ms  max=13.07ms  p(90)=1.56ms  p(95)=2.7ms  
     graphql_parse......................................: avg=9.9µs    min=3.29µs   med=4.89µs  max=6.23ms   p(90)=15.7µs  p(95)=49.2µs 
     ✓ { mode:envelop-cache-jit }.......................: avg=5.18µs   min=3.29µs   med=4.79µs  max=1.32ms   p(90)=6.7µs   p(95)=7.7µs  
     ✓ { mode:envelop-just-cache }......................: avg=4.99µs   min=3.39µs   med=4.4µs   max=6.23ms   p(90)=5.6µs   p(95)=6.6µs  
     ✓ { mode:graphql-js }..............................: avg=13.49µs  min=8.4µs    med=10.99µs max=5.68ms   p(90)=16.79µs p(95)=18.3µs 
     ✓ { mode:prom-tracing }............................: avg=52.42µs  min=43.79µs  med=50.3µs  max=1.54ms   p(90)=58µs    p(95)=63µs   
     graphql_validate...................................: avg=52.73µs  min=1.4µs    med=2.1µs   max=14.76ms  p(90)=259.9µs p(95)=266.6µs
     ✓ { mode:envelop-cache-jit }.......................: avg=2.03µs   min=1.4µs    med=1.9µs   max=1.35ms   p(90)=2.5µs   p(95)=2.6µs  
     ✓ { mode:envelop-just-cache }......................: avg=2.4µs    min=1.49µs   med=2.09µs  max=8.18ms   p(90)=2.39µs  p(95)=2.6µs  
     ✓ { mode:graphql-js }..............................: avg=285.48µs min=228.2µs  med=260.9µs max=14.76ms  p(90)=282.2µs p(95)=304.3µs
     ✓ { mode:prom-tracing }............................: avg=6.53µs   min=4.9µs    med=5.89µs  max=1.58ms   p(90)=7.5µs   p(95)=9.85µs 
     http_req_blocked...................................: avg=2.96µs   min=700ns    med=1.4µs   max=8.79ms   p(90)=2.1µs   p(95)=2.5µs  
     http_req_connecting................................: avg=237ns    min=0s       med=0s      max=4.42ms   p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.57ms   min=190.5µs  med=2.88ms  max=109.66ms p(90)=9.91ms  p(95)=15.95ms
       { expected_response:true }.......................: avg=4.57ms   min=190.5µs  med=2.88ms  max=109.66ms p(90)=9.91ms  p(95)=15.95ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.52ms   min=389µs    med=2.78ms  max=42.89ms  p(90)=5.76ms  p(95)=6.7ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=2.69ms   min=190.5µs  med=2.03ms  max=33.06ms  p(90)=5.22ms  p(95)=9.53ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.72ms   min=384.5µs  med=2.88ms  max=40.57ms  p(90)=6.06ms  p(95)=7.74ms 
     ✓ { mode:graphql-js }..............................: avg=7.16ms   min=788.31µs med=5.62ms  max=109.66ms p(90)=11.62ms p(95)=13.12ms
     ✓ { mode:prom-tracing }............................: avg=18.72ms  min=2.15ms   med=16.78ms max=85.48ms  p(90)=32.34ms p(95)=33.86ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 301577
     http_req_receiving.................................: avg=49.5µs   min=11.3µs   med=21.9µs  max=23.45ms  p(90)=31.8µs  p(95)=39.8µs 
     http_req_sending...................................: avg=38.94µs  min=4.7µs    med=7.7µs   max=25.94ms  p(90)=14.6µs  p(95)=24.5µs 
     http_req_tls_handshaking...........................: avg=0s       min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.49ms   min=166.5µs  med=2.84ms  max=109.53ms p(90)=9.5ms   p(95)=15.66ms
     http_reqs..........................................: 301577  2010.394433/s
     iteration_duration.................................: avg=4.96ms   min=419.4µs  med=3.18ms  max=110.69ms p(90)=10.76ms p(95)=16.52ms
     iterations.........................................: 301577  2010.394433/s
     vus................................................: 10      min=10        max=20  
     vus_max............................................: 20      min=20        max=20  

@n1ru4l n1ru4l merged commit 071f946 into main Aug 5, 2022
@n1ru4l n1ru4l deleted the fix-commonjs-module-resolution-typescript branch August 5, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants