Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@envelop/sentry] improve context type #2103

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

EmrysMyrddin
Copy link
Collaborator

Description

Use TypedExecutionArgs to let user define the type of the context and improve DX.

Type of change

  • New feature (non-breaking change which adds functionality)

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 08e3aa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/sentry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 5, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/sentry 7.1.0-alpha-20231205122638-08e3aa96 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Dec 5, 2023

💻 Website Preview

The latest changes are available as preview in: https://2d5129ae.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 865812      ✗ 0     
     data_received......................................: 3.3 GB  28 MB/s
     data_sent..........................................: 188 MB  1.6 MB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=1.86µs  min=712ns    med=1.62µs  max=8.54ms   p(90)=2.2µs   p(95)=2.49µs 
     http_req_connecting................................: avg=9ns     min=0s       med=0s      max=599.97µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.48ms  min=155.23µs med=2.12ms  max=80.89ms  p(90)=4.49ms  p(95)=5.04ms 
       { expected_response:true }.......................: avg=2.48ms  min=155.23µs med=2.12ms  max=80.89ms  p(90)=4.49ms  p(95)=5.04ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=2.57ms  min=370.41µs med=2.24ms  max=20.59ms  p(90)=4.45ms  p(95)=4.87ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.48ms  min=155.23µs med=1.18ms  max=18.29ms  p(90)=2.41ms  p(95)=2.6ms  
     ✓ { mode:envelop-just-cache }......................: avg=2.6ms   min=369.39µs med=2.25ms  max=33.41ms  p(90)=4.46ms  p(95)=4.92ms 
     ✓ { mode:graphql-js }..............................: avg=5ms     min=735.2µs  med=4.19ms  max=80.89ms  p(90)=8.38ms  p(95)=9.11ms 
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 432906
     http_req_receiving.................................: avg=34.22µs min=12.16µs  med=26.56µs max=13.53ms  p(90)=40.93µs p(95)=45.68µs
     http_req_sending...................................: avg=12.13µs min=4.5µs    med=9.65µs  max=12.12ms  p(90)=13.99µs p(95)=17.94µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.43ms  min=129.97µs med=2.07ms  max=80.83ms  p(90)=4.43ms  p(95)=4.98ms 
     http_reqs..........................................: 432906  3607.228327/s
     iteration_duration.................................: avg=2.76ms  min=357.86µs med=2.37ms  max=81.26ms  p(90)=4.79ms  p(95)=5.4ms  
     iterations.........................................: 432906  3607.228327/s
     vus................................................: 10      min=10        max=20  
     vus_max............................................: 20      min=20        max=20  

@ardatan ardatan merged commit 58d80ea into main Dec 7, 2023
17 checks passed
EmrysMyrddin added a commit that referenced this pull request Dec 12, 2023
EmrysMyrddin added a commit that referenced this pull request Dec 12, 2023
* [@envelop/sentry] improve context type

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants