Some bug with v1.1.4 with toggle y axis labels

[brutto]

Bowered the last 1.1.4 code realised that if i toggle visibility of series (just clicking on legend mark) y asix dissapeared, and when appear again -- many console errors occure about NaN attribute values, and whole svg holder moved to left in wrong position.

Test the same code with 1.1.2 (getting from examples) -- it works ok.

[kashban]

Same here, just started using this library and when clicking on a legend item to disable one series the whole chart goes blank.

This is the error I get:

TypeError: Cannot read property 'y' of undefined
at http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:21059
at Array.reduce (native)
at Array. (http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:21017)
at Object.d3.min (http://localhost:63342/SELMatrix/www/lib/charts/d3.js:47:34)
at http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:20990
at Array.forEach (native)
at Object.yExtent (http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:20947)
at Object.getVerticalDomain (http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:20364)
at Object.setScalesDomain (http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:19980)
at k.d.update (http://localhost:63342/SELMatrix/www/lib/n3-charts/line-chart.min.js:6:1300)
(anonymous function)
(anonymous function)
k.$digest
k.$apply
h.onSeriesVisibilityChange
(anonymous function)
(anonymous function)
n
t
o

[lorem--ipsum]

Guys, could you try with the master branch please ? I might have fixed the bug but it would be better if you could confirm it's working for you.

[anagrius]

Seeing the same thing on master here.

[kashban]

As far as I am concerned I was using the master branch.

[adressin]

Same issue here

[brutto]

Test v1.1.6 & current master: Y-axis dissapear without errors, but it still dissapeared. =
Can you make the Y-axis not dissapeaered as in 1.1.2 (probably point me where can i see axis code logic).

PS: btw 1.1.2 have bug with axis positioning with all-zero data points, but 1.1.6 and master seems to be fixed tihis.

PPS: Many thanks for your job and attention!

[chaosmail]

Hi @brutto, if everything works fine with v1.1.6, could you close the issue?
thanks a lot :)