Skip to content

Commit

Permalink
Fix e2e test after removal of controller manager. (knative#345)
Browse files Browse the repository at this point in the history
  • Loading branch information
n3wscott authored and Scott Nichols committed Aug 14, 2018
1 parent 42e0ca1 commit 60f4c66
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
1 change: 0 additions & 1 deletion config/config-logging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,4 @@ data:
# Log level overrides
# For all components changes are be picked up immediately.
loglevel.controller: "info"
loglevel.controller-manager: "info"
loglevel.webhook: "info"
4 changes: 0 additions & 4 deletions pkg/logconfig/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,11 @@ const (
// Named Loggers are used to override the default log level. config-logging.yaml will use the follow:
//
// loglevel.controller: "info"
// loglevel.controller-manager: "info"
// loglevel.webhook: "info"

// Controller is the name of the override key used inside of the logging config for Controller.
Controller = "controller"

// ControllerManager is the name of the override key used inside of the logging config for Controller Manager.
ControllerManager = "controller-manager"

// Webhook is the name of the override key used inside of the logging config for Webhook Controller.
Webhook = "webhook"
)
6 changes: 2 additions & 4 deletions test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,8 @@ function wait_until_flow_ready() {
kubectl get -n $NAMESPACE flows $NAME -oyaml
kubectl get -n $NAMESPACE jobs $NAME-start -oyaml
kubectl get -n $NAMESPACE feeds $NAME -oyaml
echo -e "Dumping controller manager logs"
kubectl -n knative-eventing logs `kubectl -n knative-eventing get pods -oname | grep controller-manager` controller-manager
echo -e "Dumping controller logs"
kubectl -n knative-eventing logs `kubectl -n knative-eventing get pods -oname | grep eventing-controller`
echo -e "Dumping eventing controller logs"
kubectl -n knative-eventing logs `kubectl -n knative-eventing get pods -oname | grep eventing-controller` eventing-controller
return 1
}

Expand Down

0 comments on commit 60f4c66

Please sign in to comment.