Fix a number of federation bugs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hamishcoleman
commented
Apr 30, 2024
hamishcoleman
commented
- Federated MAC addresses would regularly be timed out and deleted due to a faulty "last_seen" update.
- Federated supernodes would have trouble registering due to a bad boolean conversion.
- Some additional refactoring and monitoring was also added while tracking these down
There is only one place they are used, so defining them in the same file is helps both with context and in limiting the external surface area.
Migrate some peer specific macros to the peer_info internal header
Currently, only exports the federated supernode association data, but is planned to be expanded from that
Introduced when converting to use bool type in commit 11d7d08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.