TCP mode bug fixes and more #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hamishcoleman
commented
May 9, 2024
hamishcoleman
commented
- Improve built dpkg version numbers
- Clearly show API buffer overflows
- Allow management unix sock to have different perms
- Continue improving the unstable /metrics endpoint
- Keep metrics of time spent waiting for name resolution
- Fix some DEL_P2P event reporting
- Fix a couple of bugs in TCP socket disconnect/reconnect handling
Something about the ubnuts autoconf means that the autogen does not install the config.sub and/or config.guess, but some of the files can still be marked and ignored
Some times the autoreconf will create the required files and sometimes it will just complain that the files are missing. If we include the files as part of the repo to avoid the missing errors, then we will often have a dirty repository when doing builds. Walk a middle line, trying to have our cake and not lie about it.
Add a feature to the strbuf to allow tracking the overflowed status and if this is seen, append an overflow string to the API result. Could possibly also change the http result code in the future.
Eventually, a paginated interface or a streaming interface should be added - the buffers cannot simply be increased all the time. Also suggests that some form of buffer shrinking could be useful, but that can lead to exactly the fragmentation that the pre-allocated buffer is supposed to avoid
Be sure to include a column showing which community the mac address is associated with.
We were mistakenly posting an event for the deletion of a peer from the pending list, just before we added it to the known list.
…ers currently have it pre installed
Some bug reports that edges using TCP mode are getting occasional errors: *** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated We were not accounting for the fact that the TCP supernode socket file descriptor is set to "-1" when it is disconnected and invalid. Avoid "-1" file handles when adding to or checking signals for fd_set contents. This code path will hopefully also get smoothed out when the mainloop conversion is added in - as it will have a systematic way to add/check file descriptors. (Addresses n42n#28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.