Update for OpenWrt #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishcoleman
added a commit
to hamishcoleman/n3n
that referenced
this pull request
Aug 2, 2024
It turns out that the openwrt systems that I have been using to test my OpenWRT package builds (All Turris Omnia systems) appears to have had a vendor patch applied to create a symlink from "/run" to "/var/run". On a vanilla OpenWRT system, there is no "/run". Use the new configure option to set the correct run dir location. (Also deal with the OpenWRT auto conf tools being too old to include the runstatedir option) (See PR n42n#48, n42n#49)
hamishcoleman
added a commit
to hamishcoleman/n3n
that referenced
this pull request
Aug 2, 2024
It turns out that the openwrt systems that I have been using to test my OpenWRT package builds (All Turris Omnia systems) appears to have had a vendor patch applied to create a symlink from "/run" to "/var/run". On a vanilla OpenWRT system, there is no "/run". Use the new configure option to set the correct run dir location. (Also deal with the OpenWRT auto conf tools being too old to include the runstatedir option) (See PR n42n#48, n42n#49)
|
(Note that this is the same function as proposed in PR #48, with a different patch - see that PR for the earlier discussion) |
| char *basedir = "/run/n3n"; | ||
| #else | ||
| char *basedir = "/tmp/run/n3n"; |
There was a problem hiding this comment.
The "/tmp/run" is an implementation detail - the well defined dir to use is "/var/run"
|
When I talked about adding a "config" option, I meant adding it to the I've implemented it like that in hamishcoleman@0847c26 and hamishcoleman@dae535a |
|
That has been merged in PR #50 - can you test that and confirm that it is working as expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the /tmp/run/n3n directory for OpenWrt, the libcap is not required.