Fixing property parsing issue on Rust 1.78+ #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust introduced a change to
std::slice::from_raw_parts()
that breaks this crate. The panics caused by this change occur when parsing properties with the most prevalent being those of typeTDH_INTYPE_UNICODESTRING
in my testing.To resolve this issue, this MR adds checks to validate the assertions made in
std::slice::from_raw_parts()
. These are:isize::MAX
I focused on resolving the wide string conversion, but I also added a proposed fixed for arrays though I was unable to validate it.
Reference: