Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
pathconf()
always errors in qemu, and when running IDO with-g3
this causes it to allocate to a heap buffer with a size too small. When the compiler encounters a long path name it overflows this buffer, which can corrupt the heap and eventually lead to a segfault. Currently this prevents OOT retail versions from building with qemu-irix.I some trouble getting this to build on modern Ubuntu. I updated a submodule path in this PR, and also had to install python2 manually. Full steps (from https://ubuntuforums.org/showthread.php?t=2486174&p=14140057#post14140057):
Then to build qemu-irix: