fix(core): Fix issue that parameters got lost in some edge cases

n8n-io · Jun 11, 2022 · 04f0bf5 · 04f0bf5
1 parent eec12f2
commit 04f0bf5
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 7 deletions.
diff --git a/packages/workflow/src/NodeHelpers.ts b/packages/workflow/src/NodeHelpers.ts
@@ -823,7 +823,7 @@ export function getNodeParameters(
 				Object.keys(propertyValues || {}).forEach((value) => {
 					returnValue[value] = {};
 				});
-				return { [nodeProperties.name]: returnValue };
+				nodeParameters[nodeProperties.name] = returnValue;
 			}
 
 			if (Object.keys(collectionValues).length !== 0 || returnDefaults) {

diff --git a/packages/workflow/test/NodeHelpers.test.ts b/packages/workflow/test/NodeHelpers.test.ts
@@ -3010,9 +3010,15 @@ describe('Workflow', () => {
 			},
 			{
 				description:
-					'complex type "collection" which contains a "fixedCollection" with "multipleValues: false" that has a collection value added but nothing to the fixedCollection',
+					'complex type "collection" which contains a "fixedCollection" with "multipleValues: false" that has all values set to the default values (by having it as an empty object) in combination with another value',
 				input: {
 					nodePropertiesArray: [
+						{
+							name: 'mode',
+							displayName: 'mode',
+							type: 'string',
+							default: 'mode1',
+						},
 						{
 							displayName: 'Options',
 							name: 'options',
@@ -3065,33 +3071,54 @@ describe('Workflow', () => {
 						},
 					],
 					nodeValues: {
+						mode: 'changed',
 						options: {
-							sort: {},
+							sort: {
+								value: {},
+							},
 						},
 					},
 				},
 				output: {
 					noneDisplayedFalse: {
 						defaultsFalse: {
+							mode: 'changed',
 							options: {
-								sort: {},
+								sort: {
+									value: {},
+								},
 							},
 						},
 						defaultsTrue: {
+							mode: 'changed',
 							options: {
-								sort: {},
+								sort: {
+									value: {
+										descending: true,
+										ordering: 'date',
+									},
+								},
 							},
 						},
 					},
 					noneDisplayedTrue: {
 						defaultsFalse: {
+							mode: 'changed',
 							options: {
-								sort: {},
+								sort: {
+									value: {},
+								},
 							},
 						},
 						defaultsTrue: {
+							mode: 'changed',
 							options: {
-								sort: {},
+								sort: {
+									value: {
+										descending: true,
+										ordering: 'date',
+									},
+								},
 							},
 						},
 					},