fix(shopify Node): fix pagination when empty fields are sent

n8n-io · Sep 2, 2022 · 071ab40 · 071ab40
1 parent 82827d0
commit 071ab40
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/packages/nodes-base/nodes/Shopify/GenericFunctions.ts b/packages/nodes-base/nodes/Shopify/GenericFunctions.ts
@@ -88,6 +88,18 @@ export async function shopifyApiRequestAllItems(
 ): Promise<any> {
 	const returnData: IDataObject[] = [];
 
+	/*
+	 	When paginating some parameters
+		(e.g. product:getAll -> title ) cannot
+		be empty in the query string, so remove
+		all the empty ones before paginating.
+	*/
+	for (const field in query) {
+		if (query[field] === '') {
+			delete query[field];
+		}
+	}
+
 	let responseData;
 
 	let uri: string | undefined;