refactor(core): Convey error stack from job failure to main (#11261)

n8n-io · Oct 15, 2024 · 190665d · 190665d
1 parent 76ab780
commit 190665d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/packages/cli/src/scaling/scaling.service.ts b/packages/cli/src/scaling/scaling.service.ts
@@ -114,6 +114,7 @@ export class ScalingService {
 			executionId,
 			workerId: this.instanceSettings.hostId,
 			errorMsg: error.message,
+			errorStack: error.stack ?? '',
 		};
 
 		await job.progress(msg);
@@ -295,12 +296,18 @@ export class ScalingService {
 					});
 					break;
 				case 'job-failed':
-					this.logger.error(`Execution ${msg.executionId} (job ${jobId}) failed`, {
-						workerId: msg.workerId,
-						errorMsg: msg.errorMsg,
-						executionId: msg.executionId,
-						jobId,
-					});
+					this.logger.error(
+						[
+							`Execution ${msg.executionId} (job ${jobId}) failed`,
+							msg.errorStack ? `\n${msg.errorStack}\n` : '',
+						].join(''),
+						{
+							workerId: msg.workerId,
+							errorMsg: msg.errorMsg,
+							executionId: msg.executionId,
+							jobId,
+						},
+					);
 					break;
 				case 'abort-job':
 					break; // only for worker

diff --git a/packages/cli/src/scaling/scaling.types.ts b/packages/cli/src/scaling/scaling.types.ts
@@ -56,6 +56,7 @@ export type JobFailedMessage = {
 	executionId: string;
 	workerId: string;
 	errorMsg: string;
+	errorStack: string;
 };
 
 /** Message sent by main to worker to abort a job. */