fix(editor): Fix merge node connectors (#5364)

* fix(editor): Fix merge node connectors * Set `stateIsDirty` from `EVENT_CONNECTION` hook
n8n-io · Feb 6, 2023 · 20356ba · 20356ba
1 parent 8d9b64e
commit 20356ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/editor-ui/src/stores/workflows.ts b/packages/editor-ui/src/stores/workflows.ts
@@ -538,7 +538,6 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
 				// TODO: Check if there is an error or whatever that is supposed to be returned
 				return;
 			}
-
 			const sourceData: IConnection = data.connection[0];
 			const destinationData: IConnection = data.connection[1];
 

diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue
@@ -2088,6 +2088,7 @@ export default mixins(
 
 							this.connectTwoNodes(sourceNodeName, outputIndex, this.pullConnActiveNodeName, 0);
 							this.pullConnActiveNodeName = null;
+							this.dropPrevented = true;
 						}
 						return;
 					}
@@ -2160,6 +2161,8 @@ export default mixins(
 					];
 
 					this.dropPrevented = true;
+					this.workflowsStore.addConnection({ connection: connectionData });
+					this.uiStore.stateIsDirty = true;
 					if (!this.suspendRecordingDetachedConnections) {
 						this.historyStore.pushCommandToUndo(new AddConnectionCommand(connectionData));
 					}
-Original file line number
+Diff line change
@@ Expand Up @@
     				// TODO: Check if there is an error or whatever that is supposed to be returned
     				return;
     			}
     			const sourceData: IConnection = data.connection[0];
     			const destinationData: IConnection = data.connection[1];
@@ Expand Down @@