feat: Add support for reading ids from file with executeBatch command (…

…#3008)
n8n-io · Mar 19, 2022 · 5658593 · 5658593
1 parent c0611a0
commit 5658593
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 10 deletions.
diff --git a/.github/workflows/test-workflows.yml b/.github/workflows/test-workflows.yml
@@ -73,7 +73,7 @@ jobs:
         shell: bash
       -
         name: Run tests
-        run: n8n/packages/cli/bin/n8n executeBatch --shallow --skipList=test-workflows/skipList.txt --shortOutput --concurrency=16 --compare=test-workflows/snapshots
+        run: n8n/packages/cli/bin/n8n executeBatch --shallow --ids=test-workflows/safeList.txt --shortOutput --concurrency=16 --compare=test-workflows/snapshots
         shell: bash
         env:
           N8N_ENCRYPTION_KEY: ${{secrets.ENCRYPTION_KEY}}

diff --git a/packages/cli/commands/executeBatch.ts b/packages/cli/commands/executeBatch.ts
@@ -76,7 +76,8 @@ export class ExecuteBatch extends Command {
 			description: 'Toggles on displaying all errors and debug messages.',
 		}),
 		ids: flags.string({
-			description: 'Specifies workflow IDs to get executed, separated by a comma.',
+			description:
+				'Specifies workflow IDs to get executed, separated by a comma or a file containing the ids',
 		}),
 		concurrency: flags.integer({
 			default: 1,
@@ -244,16 +245,25 @@ export class ExecuteBatch extends Command {
 		}
 
 		if (flags.ids !== undefined) {
-			const paramIds = flags.ids.split(',');
-			const re = /\d+/;
-			const matchedIds = paramIds.filter((id) => re.exec(id)).map((id) => parseInt(id.trim(), 10));
+			if (fs.existsSync(flags.ids)) {
+				const contents = fs.readFileSync(flags.ids, { encoding: 'utf-8' });
+				ids.push(...contents.split(',').map((id) => parseInt(id.trim(), 10)));
+			} else {
+				const paramIds = flags.ids.split(',');
+				const re = /\d+/;
+				const matchedIds = paramIds
+					.filter((id) => re.exec(id))
+					.map((id) => parseInt(id.trim(), 10));
+
+				if (matchedIds.length === 0) {
+					console.log(
+						`The parameter --ids must be a list of numeric IDs separated by a comma or a file with this content.`,
+					);
+					return;
+				}
 
-			if (matchedIds.length === 0) {
-				console.log(`The parameter --ids must be a list of numeric IDs separated by a comma.`);
-				return;
+				ids.push(...matchedIds);
 			}
-
-			ids.push(...matchedIds);
 		}
 
 		if (flags.skipList !== undefined) {