⚡ Updating type guard so it doesn't use any type

n8n-io · Nov 8, 2022 · 6ffd13e · 6ffd13e
1 parent 1073794
commit 6ffd13e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/editor-ui/src/components/NodeCredentials.vue b/packages/editor-ui/src/components/NodeCredentials.vue
@@ -192,6 +192,7 @@ export default mixins(
 
 			return styles;
 		},
+		// TODO: Investigate if this can be solved using only the store data (storing selected flag in credentials objects, ...)
 		listenForNewCredentials() {
 			// Listen for credentials store changes so credential selection can be updated if creds are changed from the modal
 			this.credentialsStore.$subscribe((mutation, state) => {

diff --git a/packages/editor-ui/src/typeGuards.ts b/packages/editor-ui/src/typeGuards.ts
@@ -9,6 +9,6 @@ export function isNotNull<T>(value: T | null): value is T {
 	return value !== null;
 }
 
-export function isValidCredentialResponse(value: Record<string, any>): value is ICredentialsResponse {
-	return 'id' in value && 'createdAt' in value && 'createdAt' in value;
+export function isValidCredentialResponse(value: unknown): value is ICredentialsResponse {
+	return typeof value === 'object' && value !== null && 'id' in value && 'createdAt' in value && 'updatedAt' in value;
 }