Skip to content

Commit

Permalink
fix(editor): Remove infinite loading in not found workflow level exec…
Browse files Browse the repository at this point in the history
…ution (#5174)

fix(editor): Getting rid of infinite loading in workflow level execution view
  • Loading branch information
cstuncsik authored Jan 23, 2023
1 parent 6834921 commit 96dddf1
Showing 1 changed file with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,12 @@ export default mixins(
computed: {
...mapStores(useTagsStore, useNodeTypesStore, useSettingsStore, useUIStore, useWorkflowsStore),
hidePreview(): boolean {
const nothingToShow = this.executions.length === 0 && this.filterApplied;
const activeNotPresent =
this.filterApplied &&
(this.executions as IExecutionsSummary[]).find(
(ex) => ex.id === this.activeExecution.id,
) === undefined;
return this.loading || nothingToShow || activeNotPresent;
return this.loading || !this.executions.length || activeNotPresent;
},
filterApplied(): boolean {
return this.filter.status !== '';
Expand Down Expand Up @@ -393,9 +392,7 @@ export default mixins(
return [];
}
try {
const executions: IExecutionsSummary[] =
await this.workflowsStore.loadCurrentWorkflowExecutions(this.filter);
return executions;
return await this.workflowsStore.loadCurrentWorkflowExecutions(this.filter);
} catch (error) {
this.$showError(error, this.$locale.baseText('executionsList.showError.refreshData.title'));
return [];
Expand Down

0 comments on commit 96dddf1

Please sign in to comment.