feat(core): Add support for $("NodeName").isExecuted (#8683)

n8n-io · Feb 20, 2024 · ad82f0c · ad82f0c
1 parent e2f2fc9
commit ad82f0c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/workflow/src/WorkflowDataProxy.ts b/packages/workflow/src/WorkflowDataProxy.ts
@@ -922,17 +922,14 @@ export class WorkflowDataProxy {
 					throw createExpressionError(`"${nodeName}" node doesn't exist`);
 				}
 
-				if (!that?.runExecutionData?.resultData?.runData.hasOwnProperty(nodeName)) {
-					throw createExpressionError(`no data, execute "${nodeName}" node first`);
-				}
-
 				return new Proxy(
 					{},
 					{
 						has: () => true,
 						ownKeys() {
 							return [
 								'pairedItem',
+								'isExecuted',
 								'itemMatching',
 								'item',
 								'first',
@@ -945,6 +942,12 @@ export class WorkflowDataProxy {
 						get(target, property, receiver) {
 							if (property === 'isProxy') return true;
 
+							if (!that?.runExecutionData?.resultData?.runData.hasOwnProperty(nodeName)) {
+								if (property === 'isExecuted') return false;
+								throw createExpressionError(`no data, execute "${nodeName}" node first`);
+							}
+							if (property === 'isExecuted') return true;
+
 							if (['pairedItem', 'itemMatching', 'item'].includes(property as string)) {
 								const pairedItemMethod = (itemIndex?: number) => {
 									if (itemIndex === undefined) {

diff --git a/packages/workflow/test/WorkflowDataProxy.test.ts b/packages/workflow/test/WorkflowDataProxy.test.ts
@@ -294,8 +294,9 @@ describe('WorkflowDataProxy', () => {
 			expect(() => proxy.$('doNotExist')).toThrowError(ExpressionError);
 		});
 
-		test('$("NodeName")', () => {
-			expect(() => proxy.$('Set')).toThrowError(ExpressionError);
+		test('test $("NodeName").isExecuted', () => {
+			expect(proxy.$('Function').isExecuted).toEqual(true);
+			expect(proxy.$('Set').isExecuted).toEqual(false);
 		});
 
 		test('test $input.all()', () => {