refactor(editor): Rename event

n8n-io · Aug 21, 2024 · b4796c9 · b4796c9
1 parent 7f8cb11
commit b4796c9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/packages/editor-ui/src/components/CodeNodeEditor/CodeNodeEditor.vue b/packages/editor-ui/src/components/CodeNodeEditor/CodeNodeEditor.vue
@@ -118,7 +118,7 @@ const i18n = useI18n();
 const telemetry = useTelemetry();
 
 onMounted(() => {
-	if (!props.isReadOnly) codeNodeEditorEventBus.on('error-line-number', highlightLine);
+	if (!props.isReadOnly) codeNodeEditorEventBus.on('highlightLine', highlightLine);
 
 	codeNodeEditorEventBus.on('codeDiffApplied', diffApplied);
 
@@ -188,7 +188,7 @@ onMounted(() => {
 
 onBeforeUnmount(() => {
 	codeNodeEditorEventBus.off('codeDiffApplied', diffApplied);
-	if (!props.isReadOnly) codeNodeEditorEventBus.off('error-line-number', highlightLine);
+	if (!props.isReadOnly) codeNodeEditorEventBus.off('highlightLine', highlightLine);
 });
 
 const aiEnabled = computed(() => {

diff --git a/packages/editor-ui/src/components/SqlEditor/SqlEditor.vue b/packages/editor-ui/src/components/SqlEditor/SqlEditor.vue
@@ -154,15 +154,15 @@ watch(segments, () => {
 });
 
 onMounted(() => {
-	codeNodeEditorEventBus.on('error-line-number', highlightLine);
+	codeNodeEditorEventBus.on('highlightLine', highlightLine);
 
 	if (props.fullscreen) {
 		focus();
 	}
 });
 
 onBeforeUnmount(() => {
-	codeNodeEditorEventBus.off('error-line-number', highlightLine);
+	codeNodeEditorEventBus.off('highlightLine', highlightLine);
 });
 
 function line(lineNumber: number): Line | null {

diff --git a/packages/editor-ui/src/composables/usePushConnection.ts b/packages/editor-ui/src/composables/usePushConnection.ts
@@ -295,7 +295,7 @@ export function usePushConnection({ router }: { router: ReturnType<typeof useRou
 
 			const lineNumber = runDataExecuted?.data?.resultData?.error?.lineNumber;
 
-			codeNodeEditorEventBus.emit('error-line-number', lineNumber || 'final');
+			codeNodeEditorEventBus.emit('highlightLine', lineNumber ?? 'final');
 
 			const workflow = workflowHelpers.getCurrentWorkflow();
 			if (runDataExecuted.waitTill !== undefined) {

diff --git a/packages/editor-ui/src/event-bus/code-node-editor.ts b/packages/editor-ui/src/event-bus/code-node-editor.ts
@@ -1,13 +1,13 @@
 import { createEventBus } from 'n8n-design-system/utils';
 
-export type ErrorLineNumberEvent = number | 'final';
+export type HighlightLineEvent = number | 'final';
 
 export interface CodeNodeEditorEventBusEvents {
 	/** Event that a diff have been applied to the code node editor */
 	codeDiffApplied: never;
 
 	/** Command to highlight a specific line in the code node editor */
-	'error-line-number': ErrorLineNumberEvent;
+	highlightLine: HighlightLineEvent;
 }
 
 export const codeNodeEditorEventBus = createEventBus<CodeNodeEditorEventBusEvents>();