fix(editor): Fix problem with HTTP Request Node 1 credentials to be s…

…et (#3371)
n8n-io · May 24, 2022 · c5fc3bc · c5fc3bc
1 parent e5d9a7b
commit c5fc3bc
Showing 1 changed file with 18 additions and 17 deletions.
diff --git a/packages/editor-ui/src/components/mixins/workflowHelpers.ts b/packages/editor-ui/src/components/mixins/workflowHelpers.ts
@@ -330,23 +330,24 @@ export const workflowHelpers = mixins(
 					if (node.credentials !== undefined && nodeType.credentials !== undefined) {
 						const saveCredenetials: INodeCredentials = {};
 						for (const nodeCredentialTypeName of Object.keys(node.credentials)) {
-							if (this.hasProxyAuth(node) || Object.keys(node.parameters).includes('genericAuthType')) {
-								saveCredenetials[nodeCredentialTypeName] = node.credentials[nodeCredentialTypeName];
-								continue;
-							}
-
-							const credentialTypeDescription = nodeType.credentials
-								.find((credentialTypeDescription) => credentialTypeDescription.name === nodeCredentialTypeName);
-
-							if (credentialTypeDescription === undefined) {
-								// Credential type is not know so do not save
-								continue;
-							}
-
-							if (this.displayParameter(node.parameters, credentialTypeDescription, '', node) === false) {
-								// Credential should not be displayed so do also not save
-								continue;
-							}
+							// todo revert to only set actually used credentials on workflow
+							// if (this.hasProxyAuth(node) || Object.keys(node.parameters).includes('genericAuthType')) {
+							// 	saveCredenetials[nodeCredentialTypeName] = node.credentials[nodeCredentialTypeName];
+							// 	continue;
+							// }
+
+							// const credentialTypeDescription = nodeType.credentials
+							// 	.find((credentialTypeDescription) => credentialTypeDescription.name === nodeCredentialTypeName);
+
+							// if (credentialTypeDescription === undefined) {
+							// 	// Credential type is not know so do not save
+							// 	continue;
+							// }
+
+							// if (this.displayParameter(node.parameters, credentialTypeDescription, '', node) === false) {
+							// 	// Credential should not be displayed so do also not save
+							// 	continue;
+							// }
 
 							saveCredenetials[nodeCredentialTypeName] = node.credentials[nodeCredentialTypeName];
 						}