feat(editor): Implement new app layout #10548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: ci: Use correct env in destroy benchmark env job (no-changelog) (#10546) refactor(editor): Standardize components sections order (no-changelog) (#10540) refactor(editor): Convert Node.vue component to composition API (no-changelog) (#10535) feat: Add new credentials for the HTTP Request node (#9833) fix: Pass k6 api token correctly (no-changelog) (#10536) feat: Report benchmark results (no-changelog) (#10534) test(editor): Unit tests for assistant store and new design system components (no-changelog) (#10508) refactor(editor): Migrate `App.vue` to composition api (no-changelog) (#10524) refactor(editor): Convert DeleteUserModal to composition api (no-changelog) (#10531) ci: Fix fetch depth in benchmark (no-changelog) (#10532) ci: Use correct env for benchmark nightly workflow (no-changelog) (#10529) fix(core): Update zod to the latest version (no-changelog) (#10516) feat: Benchmark env with run scripts (no-changelog) (#10477) ci: Configure eslint for benchmark cli (#10480) fix(AI Transform Node): Data Transformation > Other section should not contain node (no-changelog) (#10519) fix(editor): Prevent dialog overlay from rendering on top of AI Assistant (no-changelog) (#10509) fix: Fix resolving of k6 executable (no-changelog) (#10511) fix(core): Restore Redis cache key (#10520) # Conflicts: # packages/editor-ui/src/App.vue # packages/editor-ui/src/components/AskAssistant/AskAssistantChat.vue # packages/editor-ui/src/components/Modal.vue # packages/editor-ui/src/components/NodeDetailsView.vue
n8n-assistant
bot
added
n8n team
* master: refactor(core): Standardize filename casing for environments and eventbus (no-changelog) (#10527) fix(editor): Fix node positions update event in new canvas (no-changelog) (#10528) feat(editor): Set default canvas version to version 2 on internal deployment (no-changelog) (#10514) feat(editor): Overhaul handle rendering to allow dragging of plus button (no-changelog) (#10512)
OlegIvaniv
reviewed
Aug 27, 2024
|
Btw, found a small z-index issue when moving workflow between projects: CleanShot.2024-08-27.at.15.38.19.mp4Same for adding a new credential |
* master: refactor(core): Use `@/databases/` instead of `@db/` (no-changelog) (#10573) ci: Fix destroy benchmark env workflow (no-changelog) (#10572) feat: Add benchmarking of pooled sqlite (no-changelog) (#10550) refactor(editor): User journey link to n8n.io (#10331) fix(Wait Node): Prevent waiting until invalid date (#10523) refactor(core): Standardize filename casing for controllers and databases (no-changelog) (#10564) refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) fix(editor): Scale output item selector input width with value (#10555) refactor(core): Delete InternalHooks (no-changelog) (#10561) fix(core): Make boolean config value parsing backward-compatible (#10560) fix(Google Sheets Trigger Node): Show sheet name is too long error (#10542) fix(editor): Ensure `Datatable` component renders `All` option (#10525) fix(core): Stop explicit redis client disconnect on shutdown (#10551) ci: Use correct branch for benchmark docker build workflow (no-changelog) (#10552) refactor(core): Separate listeners in scaling service (no-changelog) (#10487)
|
|
|
|
* master: ci: Fix provenance generation during NPM publish (no-changelog) (#10586) feat(core): Expose queue metrics for Prometheus (#10559) refactor(core): Map out pubsub messages (no-changelog) (#10566) fix: Fix scenario prefix not being passed (no-changelog) (#10575) refactor(core): Convert `verbose` to `debug` logs (#10574)
OlegIvaniv
approved these changes
Aug 28, 2024
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 28, 2024
* master: (24 commits) feat(core): Switch to MJML for email templates (#10518) fix(Gmail Trigger Node): Don't return date instances, but date strings instead (#10582) fix(core): Deduplicate sentry events using error stacktraces instead (no-changelog) (#10590) feat(editor): Implement new app layout (#10548) refactor(core): Standardize filename casing for services and Public API (no-changelog) (#10579) 🚀 Release 1.57.0 (#10587) fix(editor): Add tooltips to workflow history button (#10570) ci: Fix provenance generation during NPM publish (no-changelog) (#10586) feat(core): Expose queue metrics for Prometheus (#10559) refactor(core): Map out pubsub messages (no-changelog) (#10566) fix: Fix scenario prefix not being passed (no-changelog) (#10575) refactor(core): Convert `verbose` to `debug` logs (#10574) refactor(core): Use `@/databases/` instead of `@db/` (no-changelog) (#10573) ci: Fix destroy benchmark env workflow (no-changelog) (#10572) feat: Add benchmarking of pooled sqlite (no-changelog) (#10550) refactor(editor): User journey link to n8n.io (#10331) fix(Wait Node): Prevent waiting until invalid date (#10523) refactor(core): Standardize filename casing for controllers and databases (no-changelog) (#10564) refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) fix(editor): Scale output item selector input width with value (#10555) ... # Conflicts: # packages/editor-ui/src/stores/assistant.store.ts
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing new app layout that will enable AI Assistant sidebar to render alongside the rest of the app. This also moves all modals to the app grid but leaves the option to still teleport them to the
bodyif we want them to overlay everything else.See Linear ticket for details.
Latest E2E run
Related Linear tickets, Github issues, and Community forum posts
Closes ADO2-62
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)