refactor(core): Standardize filename casing for controllers and databases (no-changelog) #10564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases (no-changelog) Follow-up to: #10527 Pending for next pass: - `cli/src/PublicApi` - `cli/src/services` - `cli/test`
ivov
commented
Aug 27, 2024
| @@ -6,7 +6,7 @@ import { DataSource as Connection } from '@n8n/typeorm'; | |||
| import { ErrorReporterProxy as ErrorReporter } from 'n8n-workflow'; | |||
|
|
|||
| import { inTest } from '@/constants'; | |||
| import { wrapMigration } from '@db/utils/migrationHelpers'; | |||
| import { wrapMigration } from '@/databases/utils/migration-helpers'; | |||
There was a problem hiding this comment.
@db → @/databases comes automatically from symbol rename via Intellisense. We can change it back to @db if need be.
There was a problem hiding this comment.
Could we have just one alias and stick to that
There was a problem hiding this comment.
I think this will need a lint rule to enforce. Right now, Intellisense sometimes autocompletes imports with relative imports, sometimes with @/databases but apparently never with the @db alias, likely that one is always manual.
There was a problem hiding this comment.
I started with @db because I think I wanted to extract all DB stuff out into a separate package. I don't know if any of the reasons I had back then make sense anymore.
perhaps we should just drop @db and replace it all with @/databases.
n8n-assistant
bot
added
core
|
For future reference, to fix filename casing in case-insensitive OS: |
netroy
approved these changes
Aug 27, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
standardize-filenames-in-controllers-and-databases
|
| Run status |
|
| Run duration | 04m 45s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
419
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
1 task
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 27, 2024
* master: refactor(core): Use `@/databases/` instead of `@db/` (no-changelog) (#10573) ci: Fix destroy benchmark env workflow (no-changelog) (#10572) feat: Add benchmarking of pooled sqlite (no-changelog) (#10550) refactor(editor): User journey link to n8n.io (#10331) fix(Wait Node): Prevent waiting until invalid date (#10523) refactor(core): Standardize filename casing for controllers and databases (no-changelog) (#10564) refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) fix(editor): Scale output item selector input width with value (#10555) refactor(core): Delete InternalHooks (no-changelog) (#10561) fix(core): Make boolean config value parsing backward-compatible (#10560) fix(Google Sheets Trigger Node): Show sheet name is too long error (#10542) fix(editor): Ensure `Datatable` component renders `All` option (#10525) fix(core): Stop explicit redis client disconnect on shutdown (#10551) ci: Use correct branch for benchmark docker build workflow (no-changelog) (#10552) refactor(core): Separate listeners in scaling service (no-changelog) (#10487)
ivov
added a commit
that referenced
this pull request
Aug 28, 2024
…PI (no-changelog) Follow-up to #10564. YAML files in Public API intentionally omitted for now. `cli` package completed. Next is setting up `unicorn/filename-case` to catch any stragglers.
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 28, 2024
* master: (24 commits) feat(core): Switch to MJML for email templates (#10518) fix(Gmail Trigger Node): Don't return date instances, but date strings instead (#10582) fix(core): Deduplicate sentry events using error stacktraces instead (no-changelog) (#10590) feat(editor): Implement new app layout (#10548) refactor(core): Standardize filename casing for services and Public API (no-changelog) (#10579) 🚀 Release 1.57.0 (#10587) fix(editor): Add tooltips to workflow history button (#10570) ci: Fix provenance generation during NPM publish (no-changelog) (#10586) feat(core): Expose queue metrics for Prometheus (#10559) refactor(core): Map out pubsub messages (no-changelog) (#10566) fix: Fix scenario prefix not being passed (no-changelog) (#10575) refactor(core): Convert `verbose` to `debug` logs (#10574) refactor(core): Use `@/databases/` instead of `@db/` (no-changelog) (#10573) ci: Fix destroy benchmark env workflow (no-changelog) (#10572) feat: Add benchmarking of pooled sqlite (no-changelog) (#10550) refactor(editor): User journey link to n8n.io (#10331) fix(Wait Node): Prevent waiting until invalid date (#10523) refactor(core): Standardize filename casing for controllers and databases (no-changelog) (#10564) refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) fix(editor): Scale output item selector input width with value (#10555) ... # Conflicts: # packages/editor-ui/src/stores/assistant.store.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #10527
Pending for next pass:
cli/src/PublicApicli/src/servicescli/test