Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add endpoint to create free AI credits #12362

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 24, 2024

Summary

Builds on top of #12361

See context in the linear ticket below.

  • Introduce new endpoint to create free AI credits managed credential.
  • Make sure managed credentials cannot be edited.
  • Make sure to return the isManaged flag to the FE. We will need to this to hide the fields in the credentials modal.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2998/[n8n-backend]-add-new-endpoint-to-save-managed-credentials

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title ado 2998 n8n backend add new endpoint to save managed credentials feat(core): Add endpoint to create free AI credits Dec 24, 2024
@RicardoE105 RicardoE105 changed the base branch from master to refactor-credential-creation-endpoint December 24, 2024 17:10
@RicardoE105 RicardoE105 requested a review from mutdmour December 24, 2024 17:12
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/services/ai.service.ts 0.00% 5 Missing ⚠️
packages/cli/src/controllers/ai.controller.ts 76.47% 2 Missing and 2 partials ⚠️
packages/@n8n/api-types/src/dto/index.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

mutdmour
mutdmour previously approved these changes Dec 27, 2024
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from refactor-credential-creation-endpoint to master December 27, 2024 13:26
@RicardoE105 RicardoE105 dismissed mutdmour’s stale review December 27, 2024 13:26

The base branch was changed.

mutdmour
mutdmour previously approved these changes Dec 27, 2024
@RicardoE105 RicardoE105 force-pushed the ado-2998-n8n-backend-add-new-endpoint-to-save-managed-credentials branch from 1eae57a to 37f0731 Compare December 27, 2024 14:17
@RicardoE105 RicardoE105 requested a review from mutdmour December 27, 2024 14:17
Copy link

cypress bot commented Dec 27, 2024

n8n    Run #8483

Run Properties:  status check passed Passed #8483  •  git commit 37f0731b80: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review ado-2998-n8n-backend-add-new-endpoint-to-save-managed-credentials
Run status status check passed Passed #8483
Run duration 04m 47s
Commit git commit 37f0731b80: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit ac4e042 into master Dec 27, 2024
39 of 43 checks passed
@RicardoE105 RicardoE105 deleted the ado-2998-n8n-backend-add-new-endpoint-to-save-managed-credentials branch December 27, 2024 14:46
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants