Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose license feature flags for free AI credits feature to frontend (no-changelog) #12363

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 24, 2024

Summary

Builds on top of #12362

  • Expose license feature flags to the FE.
  • Add new endpoint to the ai.api.ts file.
  • Add experiment for the feature
  • Make available userClaimedAiCredits in FE.

This is the ground work to be able to address -> https://linear.app/n8n/issue/ADO-2994/[n8n-fe]-add-cta-to-generate-the-credits-in-the-users-instance

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2994/[n8n-fe]-add-cta-to-generate-the-credits-in-the-users-instance

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the base branch from master to ado-2998-n8n-backend-add-new-endpoint-to-save-managed-credentials December 24, 2024 18:46
@RicardoE105 RicardoE105 changed the title expose license feature flags to frontend feat: Expose license feature flags to frontend (no-changelog) Dec 24, 2024
@RicardoE105 RicardoE105 changed the title feat: Expose license feature flags to frontend (no-changelog) feat: Expose license feature flags for free AI credits feature to frontend (no-changelog) Dec 24, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 24, 2024
@RicardoE105 RicardoE105 force-pushed the expose-license-feature-flags-to-frontend branch from 109bb3e to 6a928ad Compare December 24, 2024 19:34
@RicardoE105 RicardoE105 requested a review from mutdmour December 24, 2024 19:35
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/api/ai.ts 11.11% 8 Missing ⚠️
packages/cli/src/license.ts 0.00% 4 Missing ⚠️
packages/cli/src/services/frontend.service.ts 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

mutdmour
mutdmour previously approved these changes Dec 27, 2024
@RicardoE105 RicardoE105 force-pushed the ado-2998-n8n-backend-add-new-endpoint-to-save-managed-credentials branch from 1eae57a to 37f0731 Compare December 27, 2024 14:17
Base automatically changed from ado-2998-n8n-backend-add-new-endpoint-to-save-managed-credentials to master December 27, 2024 14:46
@RicardoE105 RicardoE105 dismissed mutdmour’s stale review December 27, 2024 14:46

The base branch was changed.

@RicardoE105 RicardoE105 force-pushed the expose-license-feature-flags-to-frontend branch from 7f40bd3 to fdbc530 Compare December 27, 2024 14:53
@RicardoE105 RicardoE105 requested a review from mutdmour December 27, 2024 14:56
Copy link

cypress bot commented Dec 27, 2024

n8n    Run #8485

Run Properties:  status check passed Passed #8485  •  git commit fdbc530fad: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review expose-license-feature-flags-to-frontend
Run status status check passed Passed #8485
Run duration 04m 46s
Commit git commit fdbc530fad: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 7ea6c8b into master Dec 27, 2024
37 checks passed
@RicardoE105 RicardoE105 deleted the expose-license-feature-flags-to-frontend branch December 27, 2024 15:23
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants