Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add free AI credits CTA #12365

Merged
merged 11 commits into from
Dec 30, 2024
Merged

feat(editor): Add free AI credits CTA #12365

merged 11 commits into from
Dec 30, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 24, 2024 •
edited
Loading

Summary

Builds on top of #12363

Demo: https://share.cleanshot.com/gcK464Kn

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2994/[n8n-fe]-add-cta-to-generate-the-credits-in-the-users-instance

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the base branch from master to expose-license-feature-flags-to-frontend December 24, 2024 20:30
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 24, 2024
@RicardoE105 RicardoE105 changed the title ado 2994 n8n fe add cta to generate the credits in the users instance v2 feat(editor) Add free AI credits CTA Dec 24, 2024
@RicardoE105 RicardoE105 changed the title feat(editor) Add free AI credits CTA feat(editor): Add free AI credits CTA Dec 24, 2024
RicardoE105
RicardoE105 commented Dec 24, 2024
View reviewed changes
packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
@@ -1061,7 +1070,9 @@ function resetCredentialData(): void {
<InlineNameEdit
:model-value="credentialName"
:subtitle="credentialType ? credentialType.displayName : ''"
:readonly="!credentialPermissions.update || !credentialType"
:readonly="
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents users from editing the credential name

RicardoE105
RicardoE105 commented Dec 24, 2024
View reviewed changes
packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
@@ -597,6 +602,10 @@ function scrollToBottom() {
}

async function retestCredential() {
if (isEditingManagedCredential.value) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not send the request as there is nothing to test on managed credentials

RicardoE105
RicardoE105 commented Dec 24, 2024
View reviewed changes
packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue
@@ -235,7 +236,10 @@ watch(showOAuthSuccessBanner, (newValue, oldValue) => {
</script>

<template>
<div>
<n8n-callout v-if="isManaged" theme="warning" icon="exclamation-triangle">
Copy link
Contributor Author

@RicardoE105 RicardoE105 Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevent user from seeing the credential values

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.74576% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...i/src/components/CredentialEdit/CredentialEdit.vue 33.33% 6 Missing ⚠️
.../editor-ui/src/components/FreeAiCreditsCallout.vue 93.54% 6 Missing ⚠️
packages/editor-ui/src/stores/credentials.store.ts 33.33% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@RicardoE105 RicardoE105 requested a review from mutdmour December 24, 2024 23:42
mutdmour
mutdmour reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. A few small comments.

packages/editor-ui/src/components/FreeAiCreditsCallout.test.ts
beforeEach(() => {
vi.clearAllMocks();

(useSettingsStore as any).mockReturnValue({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be type-safer to avoid using any here. You can find other examples of places where we have mocked the settings store, for example here packages/editor-ui/src/composables/useDebugInfo.test.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address in a follow up PR

packages/editor-ui/src/components/FreeAiCreditsCallout.vue Outdated Show resolved Hide resolved
@RicardoE105 RicardoE105 force-pushed the expose-license-feature-flags-to-frontend branch from 7f40bd3 to fdbc530 Compare December 27, 2024 14:53
Base automatically changed from expose-license-feature-flags-to-frontend to master December 27, 2024 15:23
@RicardoE105 RicardoE105 force-pushed the ado-2994-n8n-fe-add-cta-to-generate-the-credits-in-the-users-instance-v2 branch from 145007d to e38df6f Compare December 27, 2024 15:25
@RicardoE105 RicardoE105 requested a review from mutdmour December 27, 2024 15:36
@cypress Cypress
Copy link

cypress bot commented Dec 27, 2024 •
edited
Loading

n8n    Run #8494

Run Properties:  status check passed Passed #8494  •  git commit d7164166c2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review ado-2994-n8n-fe-add-cta-to-generate-the-credits-in-the-users-instance-v2
Run status status check passed Passed #8494
Run duration 04m 35s
Commit git commit d7164166c2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@RicardoE105 RicardoE105 requested a review from mutdmour December 27, 2024 20:58
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit f873196 into master Dec 30, 2024
57 checks passed
@RicardoE105 RicardoE105 deleted the ado-2994-n8n-fe-add-cta-to-generate-the-credits-in-the-users-instance-v2 branch December 30, 2024 12:35
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
@RicardoE105 @riascho
feat(editor): Add free AI credits CTA (#12365)
1f5dfaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @mutdmour