Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Allow serving icons for custom nodes with npm scoped names #5626

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix(core): Allow serving icons for custom nodes with npm scoped names #5626

merged 1 commit into from
Mar 6, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 6, 2023

Fixes #5585

Joffcom
Joffcom approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with @marcuson/n8n-nodes-ics-utils, @starfallprojects/n8n-nodes-powershell and a couple of my own non-scoped packages and all is good.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 6, 2023
@netroy netroy merged commit 45ccdd3 into master Mar 6, 2023
@netroy netroy deleted the N8N-6217-fix-community-node-icons branch March 6, 2023 12:36
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 6, 2023
@janober
Copy link
Member

janober commented Mar 10, 2023

Got released with n8n@0.219.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@netroy @sunilrr
fix(core): Allow serving icons for custom nodes with npm scoped names (…
258b3a1 
…n8n-io#5626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon broken for custom node using npm scoped name
3 participants
@netroy @janober @Joffcom