Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Make new configs consistent (no-changelog) #10393

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 14, 2024

  • Remove redundant typings
  • Remove remaining readonly modifiers ref
  • Add .config. infix for searchability
  • Convert email.ts into user-management.config.ts

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Aug 14, 2024
@netroy
Copy link
Member

netroy commented Aug 14, 2024

need to resolve the conflict

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says Remove redundant typings, but I don't seen that change. also, I'm guessing we need explicit typings for decorator metadata?

@ivov
Copy link
Contributor Author

ivov commented Aug 14, 2024

PR description says Remove redundant typings, but I don't seen that change. also, I'm guessing we need explicit typings for decorator metadata?

These leftover typings below. We used to have them to prevent readonly from overly constraining the type, but with readonly gone we can rely on natural inference.

Capture 2024-08-14 at 10 47 41@2x

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Aug 14, 2024



Test summary

401 0 0 0Flakiness 4


Run details

Project n8n
Status Passed
Commit bbbc765
Started Aug 14, 2024 9:22 AM
Ended Aug 14, 2024 9:27 AM
Duration 04:49 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

30-langchain.cy.ts Flakiness
1 Langchain Integration > should be able to open and execute Agent node
19-execution.cy.ts Flakiness
1 Execution > connections should be colored differently for pinned data > when executing a node
14-mapping.cy.ts Flakiness
1 Data mapping > maps expressions from table header
2 Data mapping > maps expressions from previous nodes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit c0811b2 into master Aug 14, 2024
27 checks passed
@ivov ivov deleted the make-new-configs-consistent branch August 14, 2024 09:30
@janober
Copy link
Member

janober commented Aug 15, 2024

Got released with n8n@1.55.0

MiloradFilipovic added a commit that referenced this pull request Aug 15, 2024
* master: (22 commits)
  refactor(editor): Type node view event bus (no-changelog) (#10396)
  refactor: Update to license SDK v2.13.1 to address dependency updates (#10422)
  refactor(core): Simplify Redis client types (no-changelog) (#10397)
  fix: Project Viewer always seeing a connection error when testing credentials (#10417)
  fix(editor): Fix incorrect node type version selection on new canvas (no-changelog) (#10412)
  fix(core): Fix payload property in `workflow-post-execute` event (#10413)
  fix: Require mfa code to change email (#10354)
  ci: Remove hard-coded package version in unit tests (no-changelog) (#10414)
  refactor(editor): Remove deleted event name from UI (#10402)
  🚀 Release 1.55.0 (#10411)
  fix: Add better error handling for chat errors (#10408)
  ci: Trigger Docker releases on tag creation instead of release publishing (no-changelog) (#10409)
  fix(AI Agent Node): Fix issues with some tools not populating (#10406)
  feat(AI Transform Node): Telemetry (no-changelog) (#10398)
  feat(AI Transform Node): New node (#10405)
  feat: Add Ask assistant behind feature flag (#9995)
  refactor(editor): Use form event bus everywhere (no-changelog) (#10394)
  fix: Remove node AI Transform node (no-changelog) (#10400)
  fix(editor): Remove `@n8n/permissions` from `n8n-workflow` (no-changelog) (#10399)
  refactor(core): Make new configs consistent (no-changelog) (#10393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants