Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gong Node): New node #10777

Merged
merged 25 commits into from
Oct 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
735170b
add gong node
feelgood-interface Sep 11, 2024
f8f251d
add gong oAuth2
feelgood-interface Sep 17, 2024
f2fc28e
add tests
feelgood-interface Sep 17, 2024
9fed6fd
review improvements
feelgood-interface Sep 17, 2024
6acfaec
review improvements
feelgood-interface Sep 26, 2024
9deb1ab
lint
feelgood-interface Sep 26, 2024
dbe26b6
fix fallback value
feelgood-interface Sep 30, 2024
6952903
use root metaData for getAll calls
feelgood-interface Oct 1, 2024
0185fc3
handle errors
feelgood-interface Oct 1, 2024
0de1ce2
Merge remote-tracking branch 'upstream/master' into gong-node
feelgood-interface Oct 1, 2024
3c7ff9b
add validation
feelgood-interface Oct 8, 2024
edfd360
flatten metaData
feelgood-interface Oct 8, 2024
660b9f4
fix tests
feelgood-interface Oct 8, 2024
65a8197
improve error message
feelgood-interface Oct 8, 2024
b6f67ff
handle error
feelgood-interface Oct 8, 2024
bcf34b0
use n8n docs
feelgood-interface Oct 15, 2024
a96fb57
use n8n docs
feelgood-interface Oct 15, 2024
5ec52e5
use typeOptions password for accessKey
feelgood-interface Oct 15, 2024
123bbc9
lint reorder import
feelgood-interface Oct 15, 2024
4b30501
cleanup code
feelgood-interface Oct 15, 2024
efc6954
abstract pagination
feelgood-interface Oct 15, 2024
e322e99
abstract error handling
feelgood-interface Oct 15, 2024
30c5d71
throw error if credentials not found
feelgood-interface Oct 15, 2024
44cca86
lint
feelgood-interface Oct 15, 2024
4c3e1bb
fix response for empty user calls, reuse call extraction
feelgood-interface Oct 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
feelgood-interface committed Sep 26, 2024

Unverified

No user is associated with the committer email.
commit 9deb1ab3ba80307f5d6d4e89f9225e3d6478e9f2
Original file line number Diff line number Diff line change
@@ -5,9 +5,7 @@ import type {
IN8nHttpFullResponse,
INodeExecutionData,
INodeProperties,
JsonObject,
} from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow';

import { getCursorPaginator, gongApiPaginateRequest } from '../GenericFunctions';

4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Gong/test/Gong.node.test.ts
Original file line number Diff line number Diff line change
@@ -5,11 +5,11 @@ import type {
IHttpRequestOptions,
} from 'n8n-workflow';
import { ExpressionEvaluatorProxy, NodeConnectionType } from 'n8n-workflow';
import { FAKE_CREDENTIALS_DATA } from '../../../test/nodes/FakeCredentialsMap';
import { gongApiResponse, gongNodeResponse } from './mocks';
import type { WorkflowTestData } from '@test/nodes/types';
import { executeWorkflow } from '@test/nodes/ExecuteWorkflow';
import * as Helpers from '@test/nodes/Helpers';
import { gongApiResponse, gongNodeResponse } from './mocks';
import { FAKE_CREDENTIALS_DATA } from '../../../test/nodes/FakeCredentialsMap';

describe('Gong Node', () => {
const baseUrl = 'https://api.gong.io';