Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Introduce worker metrics #10850

Merged
merged 7 commits into from
Sep 18, 2024
Merged

feat(core): Introduce worker metrics #10850

merged 7 commits into from
Sep 18, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 17, 2024

@ivov ivov mentioned this pull request Sep 17, 2024
Merged
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 17, 2024
despairblue
despairblue requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one issue in a test, the rest looks good 🚀

packages/cli/src/metrics/__tests__/prometheus-metrics.service.test.ts Outdated Show resolved Hide resolved
@cypress Cypress
Copy link

cypress bot commented Sep 18, 2024

n8n    Run #6936

Run Properties:  status check passed Passed #6936  •  git commit 0708d456c4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review pay-1734-worker-metrics
Run status status check passed Passed #6936
Run duration 06m 04s
Commit git commit 0708d456c4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 08ebe1e into master Sep 18, 2024
33 checks passed
@ivov ivov deleted the pay-1734-worker-metrics branch September 18, 2024 09:16
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Merged
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with n8n@1.60.0

riascho pushed a commit that referenced this pull request Sep 23, 2024
@ivov @riascho
feat(core): Introduce worker metrics (#10850)
7ebdb46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despairblue despairblue despairblue approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @despairblue