Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MQTT Node): Close connection if connection attempt fails #10873

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(MQTT Node): Close connection if connection attempt fails #10873

merged 1 commit into from
Sep 18, 2024

Conversation

tomi
Copy link
Collaborator

@tomi tomi commented Sep 18, 2024

Summary

Before:

Kapture.2024-09-18.at.15.44.23.mp4

After:

Kapture.2024-09-18.at.15.46.23.mp4

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 18, 2024
ShireenMissi
ShireenMissi approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thanks for adding tests, and adding the videos in PR description 🙏

@cypress Cypress
Copy link

cypress bot commented Sep 18, 2024 •
edited
Loading

n8n    Run #6947

Run Properties:  status check passed Passed #6947  •  git commit ee7147c6b3: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #6947
Run duration 04m 46s
Commit git commit ee7147c6b3: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi changed the title fix(Mqtt Node): Close connection if connection attempt fails fix(MQTT Node): Close connection if connection attempt fails Sep 18, 2024
@tomi tomi merged commit ee7147c into master Sep 18, 2024
33 of 34 checks passed
@tomi tomi deleted the fix-mqtt-node-test-connection-issue branch September 18, 2024 17:03
riascho pushed a commit that referenced this pull request Sep 23, 2024
@tomi @riascho
fix(MQTT Node): Close connection if connection attempt fails (#10873)
a3286f6
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomi @janober @ShireenMissi