-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Expressions display actual result of evaluating expression inside string #11257
Merged
michael-radency
merged 4 commits into
master
from
node-1742-community-issue-expressions-map-function-producing-invalid
Oct 16, 2024
Merged
fix: Expressions display actual result of evaluating expression inside string #11257
michael-radency
merged 4 commits into
master
from
node-1742-community-issue-expressions-map-function-producing-invalid
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…community-issue-expressions-map-function-producing-invalid
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
ShireenMissi
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
n8n
|
Project |
n8n
|
Run status |
|
Run duration | 04m 27s |
Commit |
|
Committer | Michael Kret |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
0
|
|
0
|
|
438
|
✅ All Cypress E2E specs passed |
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
actual result would be displayed in preview instead of parsed preview:

instead of
test [Array: [{"id": 1},[],{}]]
Related Linear tickets, Github issues, and Community forum posts
#10180
https://linear.app/n8n/issue/NODE-1742/community-issue-expressions-map-function-producing-invalid-json-body