Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expressions display actual result of evaluating expression inside string #11257

Conversation

michael-radency
Copy link
Contributor

Summary

actual result would be displayed in preview instead of parsed preview:
image
instead of test [Array: [{"id": 1},[],{}]]

Related Linear tickets, Github issues, and Community forum posts

#10180
https://linear.app/n8n/issue/NODE-1742/community-issue-expressions-map-function-producing-invalid-json-body

@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Oct 15, 2024
michael-radency and others added 2 commits October 16, 2024 13:05
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Oct 16, 2024

n8n    Run #7383

Run Properties:  status check passed Passed #7383  •  git commit 4617e8ac98: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7383
Run duration 04m 27s
Commit git commit 4617e8ac98: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 7f5f0a9 into master Oct 16, 2024
33 checks passed
@michael-radency michael-radency deleted the node-1742-community-issue-expressions-map-function-producing-invalid branch October 16, 2024 10:27
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
@janober
Copy link
Member

janober commented Oct 16, 2024

Got released with n8n@1.64.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants