fix(core): Do not debounce webhooks, triggers and pollers activation #11306
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n
|
||||||||||||||||||||||||
| Project |
n8n
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
453
|
|
✅ All Cypress E2E specs passed |
ivov
deleted the
do-not-debounce-webhooks-triggers-and-pollers-activation
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi-main setup, activating a webhook-based workflow on any main sends a message
add-webhooks-triggers-and-pollersinto the pubsub command channel, so that in response the leader main can activate the webhook.When normalizing debounce values, #11156 expanded the debounce window on this message by an extra 200ms. This delay has seemingly no effect on normal use, but we believe it is causing our benchmarking setup to fail, so remove the debouncing for this specific message. If this is correct, I'll later add tests to ensure the debounce value for this message does not change.
Context: https://n8nio.slack.com/archives/C03MZF137FV/p1729245210142909?thread_ts=1729231259.216589&cid=C03MZF137FV