Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Change dedupe value column type from varchar(255) to text #11357

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix(core): Change dedupe value column type from varchar(255) to text #11357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f934a2c
Change Value column type from varchar(255) to text
ShireenMissi Oct 23, 2024
04861e9
add table prefix and fix not null constraint
ShireenMissi Oct 23, 2024
10ca6ee
Fix mysql migration and use raw queries
ShireenMissi Oct 23, 2024
1910089
fix mysql migration
ShireenMissi Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions ...cli/src/databases/migrations/common/1729607673464-UpdateProcessedDataValueColumnToText.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import type { MigrationContext, ReversibleMigration } from '@/databases/types';

const processedDataTableName = 'processed_data';

export class UpdateProcessedDataValueColumnToText1729607673464 implements ReversibleMigration {
async up({ schemaBuilder: { addColumns, dropColumns, column }, runQuery }: MigrationContext) {
await addColumns(processedDataTableName, [column('value_temp').text.notNull]);

await runQuery(`
UPDATE ${processedDataTableName}
SET value_temp = value;
`);

await dropColumns(processedDataTableName, ['value']);

await addColumns(processedDataTableName, [column('value').text.notNull]);
ShireenMissi marked this conversation as resolved.
Show resolved Hide resolved

await runQuery(`
UPDATE ${processedDataTableName}
SET value = value_temp;
`);

await dropColumns(processedDataTableName, ['value_temp']);
}

async down({ schemaBuilder: { addColumns, dropColumns, column }, runQuery }: MigrationContext) {
await addColumns(processedDataTableName, [column('value_temp').varchar(255).notNull]);

await runQuery(`
UPDATE ${processedDataTableName}
SET value_temp = value;
`);

await dropColumns(processedDataTableName, ['value']);

await addColumns(processedDataTableName, [column('value').varchar(255).notNull]);

await runQuery(`
ShireenMissi marked this conversation as resolved.
Show resolved Hide resolved
UPDATE ${processedDataTableName}
SET value = value_temp;
`);

await dropColumns(processedDataTableName, ['value_temp']);
}
}
2 changes: 2 additions & 0 deletions packages/cli/src/databases/migrations/mysqldb/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ import { AddApiKeysTable1724951148974 } from '../common/1724951148974-AddApiKeys
import { CreateProcessedDataTable1726606152711 } from '../common/1726606152711-CreateProcessedDataTable';
import { SeparateExecutionCreationFromStart1727427440136 } from '../common/1727427440136-SeparateExecutionCreationFromStart';
import { AddMissingPrimaryKeyOnAnnotationTagMapping1728659839644 } from '../common/1728659839644-AddMissingPrimaryKeyOnAnnotationTagMapping';
import { UpdateProcessedDataValueColumnToText1729607673464 } from '../common/1729607673464-UpdateProcessedDataValueColumnToText';

export const mysqlMigrations: Migration[] = [
InitialMigration1588157391238,
Expand Down Expand Up @@ -136,4 +137,5 @@ export const mysqlMigrations: Migration[] = [
SeparateExecutionCreationFromStart1727427440136,
CreateProcessedDataTable1726606152711,
AddMissingPrimaryKeyOnAnnotationTagMapping1728659839644,
UpdateProcessedDataValueColumnToText1729607673464,
];
2 changes: 2 additions & 0 deletions packages/cli/src/databases/migrations/postgresdb/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ import { AddApiKeysTable1724951148974 } from '../common/1724951148974-AddApiKeys
import { CreateProcessedDataTable1726606152711 } from '../common/1726606152711-CreateProcessedDataTable';
import { SeparateExecutionCreationFromStart1727427440136 } from '../common/1727427440136-SeparateExecutionCreationFromStart';
import { AddMissingPrimaryKeyOnAnnotationTagMapping1728659839644 } from '../common/1728659839644-AddMissingPrimaryKeyOnAnnotationTagMapping';
import { UpdateProcessedDataValueColumnToText1729607673464 } from '../common/1729607673464-UpdateProcessedDataValueColumnToText';

export const postgresMigrations: Migration[] = [
InitialMigration1587669153312,
Expand Down Expand Up @@ -136,4 +137,5 @@ export const postgresMigrations: Migration[] = [
SeparateExecutionCreationFromStart1727427440136,
CreateProcessedDataTable1726606152711,
AddMissingPrimaryKeyOnAnnotationTagMapping1728659839644,
UpdateProcessedDataValueColumnToText1729607673464,
];
2 changes: 2 additions & 0 deletions packages/cli/src/databases/migrations/sqlite/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ import { RefactorExecutionIndices1723796243146 } from '../common/1723796243146-R
import { CreateAnnotationTables1724753530828 } from '../common/1724753530828-CreateExecutionAnnotationTables';
import { CreateProcessedDataTable1726606152711 } from '../common/1726606152711-CreateProcessedDataTable';
import { SeparateExecutionCreationFromStart1727427440136 } from '../common/1727427440136-SeparateExecutionCreationFromStart';
import { UpdateProcessedDataValueColumnToText1729607673464 } from '../common/1729607673464-UpdateProcessedDataValueColumnToText';

const sqliteMigrations: Migration[] = [
InitialMigration1588102412422,
Expand Down Expand Up @@ -130,6 +131,7 @@ const sqliteMigrations: Migration[] = [
SeparateExecutionCreationFromStart1727427440136,
CreateProcessedDataTable1726606152711,
AddMissingPrimaryKeyOnAnnotationTagMapping1728659839644,
UpdateProcessedDataValueColumnToText1729607673464,
];

export { sqliteMigrations };
Loading