Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Experimental Hot reload across all backend code (no-changelog) #11659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 8, 2024

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 19.56522% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/commands/base-command.ts 16.66% 34 Missing and 1 partial ⚠️
packages/cli/src/commands/start.ts 0.00% 1 Missing ⚠️
packages/cli/src/commands/webhook.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@netroy netroy force-pushed the hot-reload-on-all-servers branch from 9236809 to 4bff06b Compare November 26, 2024 17:59
@netroy netroy marked this pull request as ready for review November 26, 2024 17:59
@netroy netroy force-pushed the hot-reload-on-all-servers branch from 4bff06b to dfec72d Compare December 11, 2024 18:18
@netroy netroy force-pushed the hot-reload-on-all-servers branch from dfec72d to 9231b95 Compare December 11, 2024 18:23
@netroy netroy changed the title feat(core): Experimental Hot reload across all backend code feat(core): Experimental Hot reload across all backend code (no-changelog) Dec 12, 2024
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we document the limitations?
I think it would not work for:

  • adding or removing services
  • changing a service's dependencies
  • adding or removing instance level properties

Anything else?

@netroy
Copy link
Member Author

netroy commented Dec 13, 2024

adding or removing services

This can be addressed

changing a service's dependencies

This should work already.

adding or removing instance level properties

Yeah. states in services cannot be reloaded like this. That's a much trickier problem to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants