feat(editor): Use a single SVG for logo and favicon (no-changelog) #11811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
There was a problem hiding this comment.
Nice cleanup 🙌🏻
A few points from my side:
- Can we make this a
design-systemcomponent? Current implementation includes a few specific things, likereleaseChannelandlocationthat we can abstract away and passcolor,showLogoTextandshowReleaseChannelTagas props - Maybe also moving logo creation logic from
onMountedinto a composable would make it easier to mock in the test if there is no other workaround for jsdom issue
netroy
force-pushed
the
inline-svg-logo-and-favicon
branch
from
35a6a7a to
780acc0
Compare
netroy
force-pushed
the
inline-svg-logo-and-favicon
branch
2 times, most recently
from
bae1a2f to
ca08169
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
MiloradFilipovic
previously approved these changes
Nov 27, 2024
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
inline-svg-logo-and-favicon
|
| Run status |
|
| Run duration | 04m 36s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
netroy
force-pushed
the
inline-svg-logo-and-favicon
branch
from
ca08169 to
afe46ba
Compare
MiloradFilipovic
approved these changes
Dec 16, 2024
|
✅ No visual regressions found. |
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)