Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Update the universal create button interaction #12105

Merged
merged 16 commits into from
Dec 11, 2024
Merged

fix(editor): Update the universal create button interaction #12105

merged 16 commits into from
Dec 11, 2024

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Dec 9, 2024 •
edited
Loading

Summary

image

Related Linear tickets, Github issues, and Community forum posts

PAY-233

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 9, 2024
@r00gm r00gm changed the title wip: split button fix(editor): Update the universal create button interaction Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.75630% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...i/src/components/CredentialEdit/CredentialEdit.vue 0.00% 4 Missing ⚠️
...r-ui/src/components/MainHeader/WorkflowDetails.vue 0.00% 4 Missing ⚠️
...ditor-ui/src/components/Projects/ProjectHeader.vue 95.31% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cypress Cypress
Copy link

cypress bot commented Dec 10, 2024 •
edited
Loading

n8n    Run #8293

Run Properties:  status check passed Passed #8293  •  git commit fe81945824: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-2331-update-the-universal-create-button-interaction-within
Run status status check passed Passed #8293
Run duration 04m 30s
Commit git commit fe81945824: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@r00gm r00gm marked this pull request as ready for review December 10, 2024 15:45
@r00gm r00gm requested a review from cstuncsik December 11, 2024 07:34
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@r00gm r00gm merged commit 5300e0a into master Dec 11, 2024
37 checks passed
@r00gm r00gm deleted the pay-2331-update-the-universal-create-button-interaction-within branch December 11, 2024 14:23
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with n8n@1.73.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
@r00gm @riascho
fix(editor): Update the universal create button interaction (#12105)
244d9fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r00gm @janober @cstuncsik