fix(core): Fix race condition in AI tool invocation with multiple items from the parent #12169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
added
the
release/backport
…ms from the parent
netroy
force-pushed
the
fix-AI-tools-invocation-race-consition
branch
from
5639d3a to
43c59bc
Compare
OlegIvaniv
approved these changes
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-AI-tools-invocation-race-consition
|
| Run status |
|
| Run duration | 04m 35s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
Merged
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an AI agent has multiple items, it can invoke a tool once for each of those items, but that can happen concurrently.
When we increment the
runIndexin thefinallyblock, this can lead to each item executing with the samerunIndex, since the tool handling function isasync.By moving
runIndex++to where the context is created, we can now guarantee uniquerunIndexfor each tool invocation.Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)