-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(API): Allow user to be added to and removed from projects #12329
Draft
MarcL
wants to merge
6
commits into
master
Choose a base branch
from
pay-1852-public-api-delete-users-from-project
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcL
commented
Dec 20, 2024
Comment on lines
+31
to
+37
parameters: | ||
- in: path | ||
name: projectId | ||
description: The ID of the project. | ||
required: true | ||
schema: | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missing the projectId
parameter when run through an OpenAPI schema validator.
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
MarcL
changed the title
feat(API): Allow deletion of user from projects
feat(API): Allow user to be added to and removed from projects
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to add and delete users to and from projects using the public API endpoint:
Also allow the ability to alter user roles in projects.
Note: There were problems getting the integration test server to work when I referenced the
projectId.yml
schema within the OpenAPI spec rather than inlined it. As we'll be looking to improve the public API at some point in the future, I've moved all the references to inline instead.Related Linear tickets, Github issues, and Community forum posts
Partially fixes: PAY-1852
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)