Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Minor styling improvements in project settings page #12405

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix(editor): Minor styling improvements in project settings page #12405

merged 2 commits into from
Dec 30, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Dec 30, 2024 •
edited
Loading

Summary

  • Using borderless icon in project header
    image

  • Cleaning up styling

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Dec 30, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 30, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

tomi
tomi reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A before and after pic would be nice 🙏

@MiloradFilipovic
Copy link
Contributor Author

A before and after pic would be nice 🙏

Done

tomi
tomi previously approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good! Should we maybe add some more margin if the name is so long that it wraps?

image

@MiloradFilipovic
Copy link
Contributor Author

Looks mostly good! Should we maybe add some more margin if the name is so long that it wraps?

image

For sure

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Dec 30, 2024 •
edited
Loading

n8n    Run #8510

Run Properties:  status check passed Passed #8510  •  git commit 04e5f61802: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review project-settings-visual-improvements
Run status status check passed Passed #8510
Run duration 04m 48s
Commit git commit 04e5f61802: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

tomi
tomi approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback 🫶

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 09ddce0 into master Dec 30, 2024
38 checks passed
@MiloradFilipovic MiloradFilipovic deleted the project-settings-visual-improvements branch December 30, 2024 14:52
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
@MiloradFilipovic @riascho
fix(editor): Minor styling improvements in project settings page (#12405
91b0d80 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @tomi