fix(core): Only show personal credentials in the personal space #12433
+13
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
despairblue
force-pushed
the
pay-2422-credentials-in-personal-list-showing-all-credentials-i-have
branch
from
a132d81 to
ae4c810
Compare
netroy
approved these changes
Jan 8, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2422-credentials-in-personal-list-showing-all-credentials-i-have
|
| Run status |
|
| Run duration | 04m 54s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
despairblue
force-pushed
the
pay-2422-credentials-in-personal-list-showing-all-credentials-i-have
branch
from
ae4c810 to
5d409a3
Compare
netroy
previously approved these changes
Jan 9, 2025
|
|
despairblue
force-pushed
the
pay-2422-credentials-in-personal-list-showing-all-credentials-i-have
branch
from
f0c483e to
5d409a3
Compare
netroy
approved these changes
Jan 9, 2025
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-2422-credentials-in-personal-list-showing-all-credentials-i-have
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently if an owner or admin look at the personal space they see all credentials they have access to, not just the personal ones:
The reason for that is a previous fix: #9396
If a user with the global
credential:listmakes the request and passes the queryincludeScopes:truethe project filter would be ignored. That was done because the endpoint was also used to get the credentials that can be used in a node and the differentiating factor was theincludeScopesparameter.Since then we created a new API endpoint for fetching credentials that can be used in a node/worfklow and thus don't need this hack anymore: #9718
Now when we remove this hack we get the anticipated result:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2422/credentials-in-personal-list-showing-all-credentials-i-have-access-to
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)