Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix execution list hover & selection colour in dark mode #12628

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(editor): Fix execution list hover & selection colour in dark mode
  • Loading branch information
tomi committed Jan 16, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 81381ee0c41018cc6a3ecd137b89af8d211abe6e
1 change: 1 addition & 0 deletions packages/design-system/src/css/_tokens.dark.scss
Original file line number Diff line number Diff line change
@@ -227,6 +227,7 @@
--color-notification-background: var(--prim-gray-740);

// Execution
--execution-card-background: var(--color-foreground-light);
--execution-card-background-hover: var(--color-foreground-base);
--execution-selector-background: var(--prim-gray-740);
--execution-selector-text: var(--color-text-base);
1 change: 1 addition & 0 deletions packages/design-system/src/css/_tokens.scss
Original file line number Diff line number Diff line change
@@ -289,6 +289,7 @@
--execution-card-border-waiting: var(--prim-color-secondary-tint-300);
--execution-card-border-running: var(--prim-color-alt-b-tint-250);
--execution-card-border-unknown: var(--prim-gray-120);
--execution-card-background: var(--color-foreground-xlight);
--execution-card-background-hover: var(--color-foreground-light);
--execution-card-text-waiting: var(--color-secondary);
--execution-selector-background: var(--color-background-dark);
Original file line number Diff line number Diff line change
@@ -182,7 +182,7 @@ function onRetryMenuItemSelect(action: string): void {
@import '@/styles/variables';

.WorkflowExecutionsCard {
--execution-list-item-background: var(--color-foreground-xlight);
--execution-list-item-background: var(--execution-card-background);
--execution-list-item-highlight-background: var(--color-warning-tint-1);

display: flex;
@@ -200,7 +200,7 @@ function onRetryMenuItemSelect(action: string): void {
&:hover,
&.active {
.executionLink {
--execution-list-item-background: var(--color-foreground-light);
--execution-list-item-background: var(--execution-card-background-hover);
}
}