Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Use shared type for evaluation feature #13320

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Feb 17, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@r00gm r00gm changed the title Ai 721 use shared type for evaluation feature refactor :Ai 721 use shared type for evaluation feature Feb 17, 2025
@r00gm r00gm changed the title refactor :Ai 721 use shared type for evaluation feature refactor(editor): Use shared type for evaluation feature Feb 17, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename this file? Its name does not reflect the content now. Both renaming the file to some common term like evaluation.schema.ts or splitting it into multiple files (test-run.schema, test-case-execution.schema etc) will work.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants