Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PATCH /projects/:projectId/folders/:folderId endpoint to allow moving folder (no-changelog) #13574

Open
wants to merge 2 commits into
base: ado-3281-be-update-endpoint-that-return-workflows-and-folders-to-also
Choose a base branch
from

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Feb 28, 2025

Based on PR #13548

Chain of upstream PRs as of 2025-02-27

Summary

1 - Update endpoint to allow moving folder to another parent.
2 - Update delete endpoint to get parameters via query string instead of body. See discussions here.
3 - Update delete endpoint to account for case when the user is trying to transfer content to the same folder it's deleting.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3166/[be]-add-endpoint-to-move-folders

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 self-assigned this Feb 28, 2025
@RicardoE105 RicardoE105 changed the title Update PATCH /projects/:projectId/folders/:folderId endpoint Update PATCH /projects/:projectId/folders/:folderId endpoint to allow moving folder Feb 28, 2025
@RicardoE105 RicardoE105 changed the title Update PATCH /projects/:projectId/folders/:folderId endpoint to allow moving folder Update PATCH /projects/:projectId/folders/:folderId endpoint to allow moving folder (no-changelog) Feb 28, 2025
@RicardoE105 RicardoE105 requested a review from Cadiac February 28, 2025 00:55
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n8n/api-types/src/dto/folders/delete-folder.dto.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch on preventing the issue on moving workflows to the same folder that's being deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants