Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trello node improvements - N8N-3475 #3201

Merged
merged 18 commits into from
May 15, 2022

Conversation

CxGarcia
Copy link
Contributor

@CxGarcia CxGarcia commented Apr 23, 2022

adds the following operations to the Trello node - board resource:

  • inviteMemberViaEmail: Invite a new member to a board via email
  • removeMember: Remove member from board using member ID
  • addMember: Add member to board using member ID
  • getMembers: Get all members of a board

getMembers:
Screen Shot 2022-04-24 at 10 00 39 AM

addMember:
Screen Shot 2022-04-24 at 10 01 29 AM

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2022

CLA assistant check
All committers have signed the CLA.

@Joffcom Joffcom added node/improvement New feature or request community Authored by a community member labels Apr 26, 2022
@Joffcom
Copy link
Member

Joffcom commented Apr 26, 2022

Hey @CxGarcia,

Thanks for the PR I am just in the process of reviewing it now, The changes look good and they work which is handy 👍🏻 I am just thinking about maybe moving the Board Member opertations to their own resource so just checking internally to see if that makes sense.

@CxGarcia
Copy link
Contributor Author

CxGarcia commented Apr 26, 2022

hey @Joffcom

no prob 🙂

I actually thought about putting these under a different resource but ended up doing it this way to keep it in line with how the Trello API is structured (all these operations are under the /boards route)

lmk what makes the most sense to you and if necessary I can make the change

@Joffcom
Copy link
Member

Joffcom commented Apr 26, 2022

Hey @CxGarcia,

A lot of the time we would keep it to the API routes but it sort of feels right to have it as Board Members, I have pushed the change and will pass it up for the next review stage but it looks good. Thanks again for the PR 👍🏻

@Joffcom
Copy link
Member

Joffcom commented Apr 26, 2022

@CxGarcia out of interest when testing did you find that you can't add a user as an observer when using the invite by email option?

@CxGarcia
Copy link
Contributor Author

@CxGarcia out of interest when testing did you find that you can't add a user as an observer when using the invite by email option?

yes, it may be because observers only work in premium workspaces https://help.trello.com/article/791-changing-permissions-on-a-board

I'll add this in the description to avoid confusion

@RicardoE105 RicardoE105 changed the title Trello node improvements Trello node improvements - N8N-3475 May 15, 2022
@RicardoE105 RicardoE105 force-pushed the n8n-trello-board-member-operations branch from 4cc0da9 to 9ec1a62 Compare May 15, 2022 13:50
@janober janober merged commit d8870ec into n8n-io:master May 15, 2022
@janober
Copy link
Member

janober commented May 15, 2022

Thanks a lot for your contribution @CxGarcia! Got merged and will be released with the next version.

@janober janober added the Upcoming Release Will be part of the upcoming release label May 15, 2022
@janober
Copy link
Member

janober commented May 16, 2022

Got released with n8n@0.177.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants