-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trello node improvements - N8N-3475 #3201
Trello node improvements - N8N-3475 #3201
Conversation
… addMember, removeMember, getMembers
Hey @CxGarcia, Thanks for the PR I am just in the process of reviewing it now, The changes look good and they work which is handy 👍🏻 I am just thinking about maybe moving the Board Member opertations to their own resource so just checking internally to see if that makes sense. |
…member-operations
hey @Joffcom no prob 🙂 I actually thought about putting these under a different resource but ended up doing it this way to keep it in line with how the Trello API is structured (all these operations are under the lmk what makes the most sense to you and if necessary I can make the change |
Hey @CxGarcia, A lot of the time we would keep it to the API routes but it sort of feels right to have it as Board Members, I have pushed the change and will pass it up for the next review stage but it looks good. Thanks again for the PR 👍🏻 |
@CxGarcia out of interest when testing did you find that you can't add a user as an observer when using the invite by email option? |
yes, it may be because observers only work in premium workspaces https://help.trello.com/article/791-changing-permissions-on-a-board I'll add this in the description to avoid confusion |
4cc0da9
to
9ec1a62
Compare
….com/CxGarcia/n8n into CxGarcia-n8n-trello-board-member-operations
Thanks a lot for your contribution @CxGarcia! Got merged and will be released with the next version. |
Got released with |
adds the following operations to the Trello node - board resource:
getMembers:
![Screen Shot 2022-04-24 at 10 00 39 AM](https://user-images.githubusercontent.com/57994942/164966891-60ae26f0-4812-4d7a-a8c2-b787ff3431bb.png)
addMember:
![Screen Shot 2022-04-24 at 10 01 29 AM](https://user-images.githubusercontent.com/57994942/164966848-0048c489-c76a-498d-8af0-97054554b041.png)