-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data pinning build #3702
Merged
Merged
Fix data pinning build #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ✨ Add push and pop operations * ⚡ linter fixes * ⚡ linter fixes * 🐛 Fix errors and remove overwrite * 🐛 Remove errant hint * ⚡ Small change Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
* Init unit tests for telemetry * Update telemetry tests * Test Workflow execution errored event * Add new tracking logic in pulse * cleanup * interfaces * Add event_version for Workflow execution count event * add version_cli in all events * add user saved credentials event * update manual wf exec finished, fixes * improve typings, lint * add node_graph_string in User clicked execute workflow button event * add User set node operation or mode event * Add instance started event in FE * Add User clicked retry execution button event * add expression editor event * add input node type to add node event * add User stopped workflow execution wvent * add error message in saved credential event * update stop execution event * add execution preflight event * Remove instance started even tfrom FE, add session started to FE,BE * improve typing * remove node_graph as property from all events * move back from default export * move psl npm package to cli package * cr * update webhook node domain logic * fix is_valid for User saved credentials event * fix Expression Editor variable selector event * add caused_by_credential in preflight event * undo webhook_domain * change node_type to full type * add webhook_domain property in manual execution event (#3680) * add webhook_domain property in manual execution event * lint fix
…dsheets (#3234) * ⚡ Allow skipping headers when writing spreadsheets * Fix type on sheet options
…deo etc.) (#3408) * fixed send media (photo, document, video etc.) issues on Telegram Node * fixed send media (photo, document, video etc.) issues on Telegram Node * file name is optional now * ⚡ lock file and linter fix * ⚡ improvements * ⚡ fixes * ⚡ Improvements * ⚡ Add placeholder to File Name * ⚡ Add error message * 🔥 Remove requestWithAuthentication * ⚡ Fix typo * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
* Add fields and Ops for Lookup Search * Adds Search (Search + Lookup) operations * 🔨 credentials update * 🔨 improvements * ⚡ clean up and linter fixes * ⚡ merged search and query, more hints * ⚡ Improvements * ⚡ Add generic type to authentication method Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
* ✨ Add query auth for Jira Trigger security * ⚡ small fixes: * ⚡ Response with 403 when invalid query authentication * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
…ndex refresh (#2420) * 🐛 ES query string not passed to request * 🔑 Add ES credential test * ✨ Add ES index pipelines and index refresh * 🔨 merge fix * ⚡ renamed additional filds as options * ⚡ added ignore ssl to credentials * ⚡ Improvements * ⚡ Improvements * feat(Redis Node): Add push and pop operations (#3127) * ✨ Add push and pop operations * ⚡ linter fixes * ⚡ linter fixes * 🐛 Fix errors and remove overwrite * 🐛 Remove errant hint * ⚡ Small change Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * refactor: Telemetry updates (#3529) * Init unit tests for telemetry * Update telemetry tests * Test Workflow execution errored event * Add new tracking logic in pulse * cleanup * interfaces * Add event_version for Workflow execution count event * add version_cli in all events * add user saved credentials event * update manual wf exec finished, fixes * improve typings, lint * add node_graph_string in User clicked execute workflow button event * add User set node operation or mode event * Add instance started event in FE * Add User clicked retry execution button event * add expression editor event * add input node type to add node event * add User stopped workflow execution wvent * add error message in saved credential event * update stop execution event * add execution preflight event * Remove instance started even tfrom FE, add session started to FE,BE * improve typing * remove node_graph as property from all events * move back from default export * move psl npm package to cli package * cr * update webhook node domain logic * fix is_valid for User saved credentials event * fix Expression Editor variable selector event * add caused_by_credential in preflight event * undo webhook_domain * change node_type to full type * add webhook_domain property in manual execution event (#3680) * add webhook_domain property in manual execution event * lint fix * feat(SpreadsheetFile Node): Allow skipping headers when writing spreadsheets (#3234) * ⚡ Allow skipping headers when writing spreadsheets * Fix type on sheet options * fix(Telegram Node): Fix sending binaryData media (photo, document, video etc.) (#3408) * fixed send media (photo, document, video etc.) issues on Telegram Node * fixed send media (photo, document, video etc.) issues on Telegram Node * file name is optional now * ⚡ lock file and linter fix * ⚡ improvements * ⚡ fixes * ⚡ Improvements * ⚡ Add placeholder to File Name * ⚡ Add error message * 🔥 Remove requestWithAuthentication * ⚡ Fix typo * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Freshworks CRM Node): Add Search + Lookup functionality (#3131) * Add fields and Ops for Lookup Search * Adds Search (Search + Lookup) operations * 🔨 credentials update * 🔨 improvements * ⚡ clean up and linter fixes * ⚡ merged search and query, more hints * ⚡ Improvements * ⚡ Add generic type to authentication method Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * feat(Jira Trigger Node): Add optional query auth for security (#3172) * ✨ Add query auth for Jira Trigger security * ⚡ small fixes: * ⚡ Response with 403 when invalid query authentication * 👕 Fix linting issues Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> * ⚡ Changed authentication to use the generic type Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com> Co-authored-by: Ahsan Virani <ahsan.virani@gmail.com> Co-authored-by: Nicholas Penree <nick@penree.com> Co-authored-by: Taha Sönmez <35905778+tahasonmez@users.noreply.github.com> Co-authored-by: Jan Thiel <JanThiel@users.noreply.github.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
* 🔨 fix * ⚡ ui update
…#3378) * support for customer.io tracking api endpoint region selection If your account is based in our EU region use the EU endpoints (track-eu.customer.io) for US (other than EU) tracking endpoints (track.customer.io). * Changed name to keep constistency with other nodes * Switched to credentials injection * Add throwing error when unknow way of authenticating * Fixed url for http request * Add hint to region field about being omited with http node * Fix bug for credentials working with http node * Improve IF by deduplicating code Co-authored-by: h4ux <alon@h4ux.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>
… Scan FilterExpression (#3318) * FilterExpression, ExpressionAttributeValues optional * Returns AWS JSON messages not in response body * 🔨 fixed filterExpression missing in request body * ⚡ linter fixes * Reintroduced 'fix' block at :311 results in duplication * ⚡ lock file fix * ⚡ fix Co-authored-by: Michael Kret <michael.k@radency.com>
* ⚡ fix * ⚡ tlsOptions fix
* ✨ Add regex replace for Rename node * ⚡ ability to add multiple regex, case insensetivity option, UI imrovements * ⚡ UI update: * ⚡ removed hint * 🔨 UI change, regex under additional options * ⚡ added notice * ⚡ Fix order and set correct default value * 👕 Fix lint issue Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
… options on 'Document: getAll' operation (#3660) * Added 'Source Excludes' and 'Source Includes' options on 'document: getAll' operation * Updated credentials to use new system Co-authored-by: mp <miguel@mconf.com> Co-authored-by: miguel-mconf <107938570+miguel-mconf@users.noreply.github.com> Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
…3525) * Fix: process all input items in GDrive list * ⚡ linter fixes * ⚡ added versioning * ⚡ fix option naming * ⚡ removed option for choosing list operation behavior * ⚡ Improvement Co-authored-by: Yann Jouanique <yann.jouanique@gmail.com> Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
… HTTP Request Node (#3670) * Notion cred updated * Airtable new cred * revamped twilio cred * urlscanlo revamp cred * Wordpress revamp cred with testing * SendGrid cred revamped * 🐛 Fix imports * 🐛 Fixes imports in urlscanio * Fix airtable cred injection * Fixes notion request, changes way of cred injection * Change auth type from method to generic * Fix minor issues * Fix lint issue Co-authored-by: Omar Ajoue <krynble@gmail.com>
* 👕 Add `action` to `INodePropertyOptions` * 👕 Apply `node-param-operation-option-without-action` * ✏️ Fix add/remove phrasing * ✏️ Fix email template phrasing * ✏️ Fix add/remove phrasing * ✏️ Fix custom fields phrasing * ✏️ Fix job report phrasing * ✏️ Fix query phrasing * ✏️ Various phrasing fixes * ✏️ Fix final phrasings * ✏️ Remove `conversation` * ✏️ Fix plural
* ✨ Implementing N8nCheckbox Vue component * ✨ Added checkbox support to N8nFormInput component * 👌 Updating n8n-checkbox component so it supports indeterminate state and input event * 💄 Adding the `labelSize` property to the `N8nCheckbox` component
* ⚡ Add `itemIndex` to node-thrown errors * ⚡ Add some missing item indexes
* 📌 Pin `vue-fragment` to 1.5.1 * 📦 Update `package-lock.json`
…0 and n8n-workflow@0.108.0 on n8n
janober
pushed a commit
that referenced
this pull request
Jul 18, 2022
* refactor: Aligned n8n-button usage inside of editor-ui. * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * feat: Added pinData and edit mode methods. * 🔥 Remove conflict markers * ✏️ Update i18n keys * ⚡ Add JSON validation * 🗃️ Add `pinData` column to `workflow_entity` * 📘 Tighten type * ⚡ Make `pinData` column nullable * ⚡ Adjust workflow endpoints for pin data * 📘 Improve types * ✏️ Improve wording * Inject pindata into items flow (#3420) * ⚡ Inject pin data - Second approach * 🔥 Remove unneeded lint exception * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * fix: Fixed rebase conflicts. * ⏪ Undo button change * 🐛 Fix runNode call Adjust per update in bdb8413 * 🧪 Fix workflow tests * 🐛 More merge conflict fixes * feat: Added pin/unpin button and store mutations. * feat: Size check. Various design and ux improvements. * ⚡ Add transformer * ⚡ Hoist pin data * ⚡ Adjust endpoints for hoisted pin data * 📘 Expand interface * 🐛 Fix stray array * 👕 Fix build * 👕 Add lint exception * 👕 Fix header * 🎨 Add color secondary tints * ✨ Create `HeaderMessage` component * ⚡ Adjust `InfoTip` component * ✨ Add `HeaderMessage` to `RunData` * 🐛 Fix console error * 👕 Fix lint * ⚡ Consolidate `HeaderMessage` and `Callout` * ⏪ Undo `InfoTip` changes * 🔥 Remove duplicate icons * ⚡ Simplify template * 🎨 Change cursor for action text * 👕 Fix lint * ⚡ Add URL * 🐛 Fix handler name * ⚡ Use constant * ♻️ Refactor per feedback * fix: Various fixes after data pinning relocation. * fix: Added store mutation for setting pinned data. * feat: Added pinned state for workflow canvas node. * fix: Fixed workflow saving. * fix: Removed pinData hoisting (no longer necessary). * feat: Added canPinData flag to hide for input pane and binary data. Fixed unpin and execute flow. * ⚡ Fixes for canvas pin data (#3587) * ⚡ Fixes for canvas pin data * 📘 Rename type * 🧪 Fix unrelated Public API test * 🔥 Remove logging * feat: Updated pinData mixin to no longer include extra fields. * ⚡ Output same pindata for every run * 🎨 Fix cropping * 🔥 Remove unrelated logging * feat: Moved edit button next to pin button. * feat: Changed data to be inserted for empty state. * chore: Changed invalid editor output translation. * feat: Added error line reporting on JSON Validation. * feat: Migrated pinData edit mode to store. * chore: Merged duplicate node border color condition. * feat: Moved pin data validation to mixin. Added check before closing ndv modal. * fix: Changed pinned data size calculation to discard active node pin data. * feat: Added support for rename and delete node with pin data. * feat: Simplified editing state. Fixed edit mode in input panel after store migration. * feat: Various data pinning improvements. * fix: Fixed callout link underline. * refactor: Added support for both string and objects for data size check. * feat: Added disabled node check for input panel. Fixed monaco editor resizing. * fix: Fixed edit mode footer size. * ⚡ Fix pindata items per run * 👕 Remove unneeded exception * refactor: Added isValidPinData() helper method. * refactor: Changed how string size in bytes in calculated.g * refactor: Updated pinData mixin interface. * refactor: Merged filter and reduce in pinDataSize calculation. * fix: Changed code-editor to correct type. * fix: Added insert test data message to trigger nodes. * feat: Disabled data pinning for multiple output nodes. * refactor: Updated ndv.input.disabled translation to include node name. * refactor: Aligned n8n-button usage inside of editor-ui. * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * feat: Added pinData and edit mode methods. * 🔥 Remove conflict markers * ✏️ Update i18n keys * ⚡ Add JSON validation * 🗃️ Add `pinData` column to `workflow_entity` * 📘 Tighten type * ⚡ Make `pinData` column nullable * ⚡ Adjust workflow endpoints for pin data * 📘 Improve types * ✏️ Improve wording * Inject pindata into items flow (#3420) * ⚡ Inject pin data - Second approach * 🔥 Remove unneeded lint exception * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * fix: Fixed rebase conflicts. * ⏪ Undo button change * 🐛 Fix runNode call Adjust per update in bdb8413 * 🧪 Fix workflow tests * 🐛 More merge conflict fixes * feat: Added pin/unpin button and store mutations. * feat: Size check. Various design and ux improvements. * ⚡ Add transformer * ⚡ Hoist pin data * ⚡ Adjust endpoints for hoisted pin data * 📘 Expand interface * 🐛 Fix stray array * 👕 Fix build * 🎨 Add color secondary tints * ✨ Create `HeaderMessage` component * ⚡ Adjust `InfoTip` component * ✨ Add `HeaderMessage` to `RunData` * 🐛 Fix console error * 👕 Fix lint * ⚡ Consolidate `HeaderMessage` and `Callout` * ⏪ Undo `InfoTip` changes * 🔥 Remove duplicate icons * ⚡ Simplify template * 🎨 Change cursor for action text * 👕 Fix lint * ⚡ Add URL * 🐛 Fix handler name * ⚡ Use constant * ♻️ Refactor per feedback * fix: Various fixes after data pinning relocation. * fix: Added store mutation for setting pinned data. * feat: Added pinned state for workflow canvas node. * ⚡ Fixes for canvas pin data (#3587) * ⚡ Fixes for canvas pin data * 📘 Rename type * 🧪 Fix unrelated Public API test * 🔥 Remove logging * feat: Updated pinData mixin to no longer include extra fields. * fix: Removed pinData hoisting (no longer necessary). * chore: Merged duplicate node border color condition. * ⚡ Output same pindata for every run * 🎨 Fix cropping * 🐛 Fix excess closing template tag * fix: Removed rogue template tag after merge. * fix: Fixed code-editor resizing when moving ndv panel. * feat: Added node duplication pin data. * ⚡ Implement telemetry * ♻️ Add clarifications from call * fix: Fixed run data header height. * feat: Removed border from pin data callout. * feat: Added line-break before 'or insert pin data'. * feat: Changed enterEditMode to always insert test data if there's no execution data. * feat: Removed copy output tooltip. * feat: Removed unpin tooltip. * fix: Removed thumbtack icon rotation. * fix: Removed run info from Edit Output title. * feat: Hid edit and pin buttons when editing. * feat: Updated monaco code-editor padding and borders. * feat: Progress on pinData error message format * feat: Updated copy feature to work without any selected value. * feat: Moved save and cancel buttons. Cleared notifications on save. * feat: Changed pin data beforeClosing confirm text. * feat: Closing ndv when discarding or saving pindata on close. * feat: Added split in batches node to pin data denylist. * fix: Added missing margin-bottom to webhook node. * feat: Moved thumbtack icon to the right, replacing the checkmark. * fix: Hid pagination while editing. * feat: Added pin data discovery flow. * feat: Changed pin data discovery flow to avoid tooltip glitching. * fix: Changed copy selection to copy all input data. * feat: Updated pin data validation error message for unexpected single quotes. * fix: Replaced :manual='true' prop with manual shorthand. * fix: Removed unused variable. * chore: Renamed translation key to node.discovery.pinData. * refactor: Extracted isPinDataNodeType to pinData mixin. * fix: Updated watch condition to improve performance. * refactor: Renamed some pin data variables and methods as per review. * fix: Added partial translation for JSON.parse pin data error messages. * chore: Temporarily disabled failing unit test. * 🧪 Fix data pinning workflow retrieval test * 🔥 Remove unused imports * 🔥 Remove leftover line * ⚡ Skip pindata node issues on BE * ⚡ Skip pindata node issues on FE * ⚡ Hide `RunInfo` for pindata node * ⚡ Hide purple banner in edit output mode * feat: Updated data pinning discoverability flow. * fix: Fixed paginated data pinning. * fix: Disabled pin data in read only mode. * 🐛 Fix runtime error with non-array * fix: Loading pin data when opening execution. * ⚡ Adjust stale data warning for pinned data * ⚡ Skip auth in endpoint * ⚡ Mark start node for pinned trigger * ✏️ Comment on passthrough * 🔥 Remove comment * Final pindata metrics changes (#3673) * 🐛 Fix `pinData` tracked as `0` * ⚡ Add `is_pinned` to `nodesGraph` * 📘 Extend `IWorkflowBase` * ⚡ Handle `pinData` being `undefined` * ⚡ Add `data_pinning_tooltip_presented` * ♻️ Refactor to remove circular dependency * fix: Added pin data handling when importing workflow. (#3698) * 🔥 Remove helper from WorkflowExecute * ⚡ Add logic for single pinned trigger * 👕 Remove lint exception * fix: Added pin data handling in importWorkflowExact. * N8N-4077 data pinning discoverability part 2 (#3701) * fix: Fixed pin data discovery tooltip position when moving canvas. * feat: Updated data pinning discovery tooltip copy. * Fix data pinning build (#3702) * ⚡ Disable edit button for disabled node * ⚡ Ensure disabled pinned nodes are passthrough * 🐛 Fix JSON key unfurling in edit mode * ⚡ Improve implementation * 🐛 Fix console error * fix: Fixed copying pinned output data. (#3715) * Fix pinning for webhook responding with output from last node (#3719) * fix: Fixed entering edit mode after refresh. * fix: Fixed type error during build. * fix: RunData import formatting. * chore: Updated pin data types. * fix: Added missing type to stringSizeInBytes. Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
janober
pushed a commit
that referenced
this pull request
Jul 20, 2022
* feat: Design system color improvements and button component redesign. * feat: Added button focus state and unit tests. * refactor: Aligned n8n-button usage inside of editor-ui. * test: Updated snapshots. * refactor: Extracted focus outline width into scss variable. * fix: Fixed select input border-radius. * refactor: Removed element-ui references in button. * fix: Fixed scss variable imports. * feat: Added color-neutral variable story. * fix: Fixed color-secondary variable definition. * feat: Added color-white story. * test: Updated button snapshot. * feat: Replaced zoom buttons with new n8n-icon-button. * feat: Added stories for float utilities. * chore: Updated color shades generation code for later use. * chore: Removed color-white code. * chore: Updated story properties for button components. * fix: Added el-button fallback for places where el-button is not replaceable (messagebox). * feat: Reverted to css modules. Replaced el-button with n8n-button at application level. * test: Updated button snapshot. * fix: Fixed element-ui locally referenced buttons (via components: {}). * fix: Updated colors. Removed irrelevant validation. Added ElButton override component. * test: Updated button override snapshot. * fix: Various button adjustments and fixes. * fix: Updated button disabled state. * test: Updated snapshots. * fix: Consolidated css variables changes. * Data pinning (#3512) * refactor: Aligned n8n-button usage inside of editor-ui. * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * feat: Added pinData and edit mode methods. * 🔥 Remove conflict markers * ✏️ Update i18n keys * ⚡ Add JSON validation * 🗃️ Add `pinData` column to `workflow_entity` * 📘 Tighten type * ⚡ Make `pinData` column nullable * ⚡ Adjust workflow endpoints for pin data * 📘 Improve types * ✏️ Improve wording * Inject pindata into items flow (#3420) * ⚡ Inject pin data - Second approach * 🔥 Remove unneeded lint exception * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * fix: Fixed rebase conflicts. * ⏪ Undo button change * 🐛 Fix runNode call Adjust per update in bdb8413 * 🧪 Fix workflow tests * 🐛 More merge conflict fixes * feat: Added pin/unpin button and store mutations. * feat: Size check. Various design and ux improvements. * ⚡ Add transformer * ⚡ Hoist pin data * ⚡ Adjust endpoints for hoisted pin data * 📘 Expand interface * 🐛 Fix stray array * 👕 Fix build * 👕 Add lint exception * 👕 Fix header * 🎨 Add color secondary tints * ✨ Create `HeaderMessage` component * ⚡ Adjust `InfoTip` component * ✨ Add `HeaderMessage` to `RunData` * 🐛 Fix console error * 👕 Fix lint * ⚡ Consolidate `HeaderMessage` and `Callout` * ⏪ Undo `InfoTip` changes * 🔥 Remove duplicate icons * ⚡ Simplify template * 🎨 Change cursor for action text * 👕 Fix lint * ⚡ Add URL * 🐛 Fix handler name * ⚡ Use constant * ♻️ Refactor per feedback * fix: Various fixes after data pinning relocation. * fix: Added store mutation for setting pinned data. * feat: Added pinned state for workflow canvas node. * fix: Fixed workflow saving. * fix: Removed pinData hoisting (no longer necessary). * feat: Added canPinData flag to hide for input pane and binary data. Fixed unpin and execute flow. * ⚡ Fixes for canvas pin data (#3587) * ⚡ Fixes for canvas pin data * 📘 Rename type * 🧪 Fix unrelated Public API test * 🔥 Remove logging * feat: Updated pinData mixin to no longer include extra fields. * ⚡ Output same pindata for every run * 🎨 Fix cropping * 🔥 Remove unrelated logging * feat: Moved edit button next to pin button. * feat: Changed data to be inserted for empty state. * chore: Changed invalid editor output translation. * feat: Added error line reporting on JSON Validation. * feat: Migrated pinData edit mode to store. * chore: Merged duplicate node border color condition. * feat: Moved pin data validation to mixin. Added check before closing ndv modal. * fix: Changed pinned data size calculation to discard active node pin data. * feat: Added support for rename and delete node with pin data. * feat: Simplified editing state. Fixed edit mode in input panel after store migration. * feat: Various data pinning improvements. * fix: Fixed callout link underline. * refactor: Added support for both string and objects for data size check. * feat: Added disabled node check for input panel. Fixed monaco editor resizing. * fix: Fixed edit mode footer size. * ⚡ Fix pindata items per run * 👕 Remove unneeded exception * refactor: Added isValidPinData() helper method. * refactor: Changed how string size in bytes in calculated.g * refactor: Updated pinData mixin interface. * refactor: Merged filter and reduce in pinDataSize calculation. * fix: Changed code-editor to correct type. * fix: Added insert test data message to trigger nodes. * feat: Disabled data pinning for multiple output nodes. * refactor: Updated ndv.input.disabled translation to include node name. * refactor: Aligned n8n-button usage inside of editor-ui. * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * feat: Added pinData and edit mode methods. * 🔥 Remove conflict markers * ✏️ Update i18n keys * ⚡ Add JSON validation * 🗃️ Add `pinData` column to `workflow_entity` * 📘 Tighten type * ⚡ Make `pinData` column nullable * ⚡ Adjust workflow endpoints for pin data * 📘 Improve types * ✏️ Improve wording * Inject pindata into items flow (#3420) * ⚡ Inject pin data - Second approach * 🔥 Remove unneeded lint exception * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * fix: Fixed rebase conflicts. * ⏪ Undo button change * 🐛 Fix runNode call Adjust per update in bdb8413 * 🧪 Fix workflow tests * 🐛 More merge conflict fixes * feat: Added pin/unpin button and store mutations. * feat: Size check. Various design and ux improvements. * ⚡ Add transformer * ⚡ Hoist pin data * ⚡ Adjust endpoints for hoisted pin data * 📘 Expand interface * 🐛 Fix stray array * 👕 Fix build * 🎨 Add color secondary tints * ✨ Create `HeaderMessage` component * ⚡ Adjust `InfoTip` component * ✨ Add `HeaderMessage` to `RunData` * 🐛 Fix console error * 👕 Fix lint * ⚡ Consolidate `HeaderMessage` and `Callout` * ⏪ Undo `InfoTip` changes * 🔥 Remove duplicate icons * ⚡ Simplify template * 🎨 Change cursor for action text * 👕 Fix lint * ⚡ Add URL * 🐛 Fix handler name * ⚡ Use constant * ♻️ Refactor per feedback * fix: Various fixes after data pinning relocation. * fix: Added store mutation for setting pinned data. * feat: Added pinned state for workflow canvas node. * ⚡ Fixes for canvas pin data (#3587) * ⚡ Fixes for canvas pin data * 📘 Rename type * 🧪 Fix unrelated Public API test * 🔥 Remove logging * feat: Updated pinData mixin to no longer include extra fields. * fix: Removed pinData hoisting (no longer necessary). * chore: Merged duplicate node border color condition. * ⚡ Output same pindata for every run * 🎨 Fix cropping * 🐛 Fix excess closing template tag * fix: Removed rogue template tag after merge. * fix: Fixed code-editor resizing when moving ndv panel. * feat: Added node duplication pin data. * ⚡ Implement telemetry * ♻️ Add clarifications from call * fix: Fixed run data header height. * feat: Removed border from pin data callout. * feat: Added line-break before 'or insert pin data'. * feat: Changed enterEditMode to always insert test data if there's no execution data. * feat: Removed copy output tooltip. * feat: Removed unpin tooltip. * fix: Removed thumbtack icon rotation. * fix: Removed run info from Edit Output title. * feat: Hid edit and pin buttons when editing. * feat: Updated monaco code-editor padding and borders. * feat: Progress on pinData error message format * feat: Updated copy feature to work without any selected value. * feat: Moved save and cancel buttons. Cleared notifications on save. * feat: Changed pin data beforeClosing confirm text. * feat: Closing ndv when discarding or saving pindata on close. * feat: Added split in batches node to pin data denylist. * fix: Added missing margin-bottom to webhook node. * feat: Moved thumbtack icon to the right, replacing the checkmark. * fix: Hid pagination while editing. * feat: Added pin data discovery flow. * feat: Changed pin data discovery flow to avoid tooltip glitching. * fix: Changed copy selection to copy all input data. * feat: Updated pin data validation error message for unexpected single quotes. * fix: Replaced :manual='true' prop with manual shorthand. * fix: Removed unused variable. * chore: Renamed translation key to node.discovery.pinData. * refactor: Extracted isPinDataNodeType to pinData mixin. * fix: Updated watch condition to improve performance. * refactor: Renamed some pin data variables and methods as per review. * fix: Added partial translation for JSON.parse pin data error messages. * chore: Temporarily disabled failing unit test. * 🧪 Fix data pinning workflow retrieval test * 🔥 Remove unused imports * 🔥 Remove leftover line * ⚡ Skip pindata node issues on BE * ⚡ Skip pindata node issues on FE * ⚡ Hide `RunInfo` for pindata node * ⚡ Hide purple banner in edit output mode * feat: Updated data pinning discoverability flow. * fix: Fixed paginated data pinning. * fix: Disabled pin data in read only mode. * 🐛 Fix runtime error with non-array * fix: Loading pin data when opening execution. * ⚡ Adjust stale data warning for pinned data * ⚡ Skip auth in endpoint * ⚡ Mark start node for pinned trigger * ✏️ Comment on passthrough * 🔥 Remove comment * Final pindata metrics changes (#3673) * 🐛 Fix `pinData` tracked as `0` * ⚡ Add `is_pinned` to `nodesGraph` * 📘 Extend `IWorkflowBase` * ⚡ Handle `pinData` being `undefined` * ⚡ Add `data_pinning_tooltip_presented` * ♻️ Refactor to remove circular dependency * fix: Added pin data handling when importing workflow. (#3698) * 🔥 Remove helper from WorkflowExecute * ⚡ Add logic for single pinned trigger * 👕 Remove lint exception * fix: Added pin data handling in importWorkflowExact. * N8N-4077 data pinning discoverability part 2 (#3701) * fix: Fixed pin data discovery tooltip position when moving canvas. * feat: Updated data pinning discovery tooltip copy. * Fix data pinning build (#3702) * ⚡ Disable edit button for disabled node * ⚡ Ensure disabled pinned nodes are passthrough * 🐛 Fix JSON key unfurling in edit mode * ⚡ Improve implementation * 🐛 Fix console error * fix: Fixed copying pinned output data. (#3715) * Fix pinning for webhook responding with output from last node (#3719) * fix: Fixed entering edit mode after refresh. * fix: Fixed type error during build. * fix: RunData import formatting. * chore: Updated pin data types. * fix: Added missing type to stringSizeInBytes. Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * fix: Showing pin data without executing the node only in output pane. * fix: Updated no data message when previous node not executed. * feat: Added expression input and evaluation for pin data nodes without execution. * chore: Fixed linting issues and removed remnant console.log(). * chore: Undone package-lock changes. * fix: Removed pin data store changes. * fix: Created a new object using vuex runExecutionData. * fix: Fixed bug appearing when adding a new node after executing. * fix: Fix editor-ui build * feat: Added green node connectors when having pin data output. * chore: Fixed linting errors. * fix: Added pin data eventBus unsubscribe. * fix: Added pin data color check after adding a connection. * 🎨 Add pindata styles Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.