Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pairedItem for pinned data #3843

Merged
merged 24 commits into from
Aug 22, 2022
Merged

Support pairedItem for pinned data #3843

merged 24 commits into from
Aug 22, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 5, 2022 •
edited
Loading

Client:

  • Add json key in store mutation
  • Clear json key if added by user
  • Remove auto-added json key in RunData.vue

Server:

  • Clear json key addition from execution flow
  • Migrate existing pindata without json on sqlite
  • Migrate existing pindata without json on MySQL
  • Migrate existing pindata without json on Postgres
  • Adjust tests
  • Clean up some migration helpers

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 5, 2022
@ivov ivov changed the title Support pairedItem for pinned data on client Support pairedItem for pinned data Aug 9, 2022
alexgrozav
alexgrozav requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this, Iván!

Here are two issues that I found:

  • Copy selection (copying whole json, unselected) now copies with json key
  • Pinning and then editing shows up with a json key in the editor (for both executions and manual edits)

@alexgrozav alexgrozav self-requested a review August 22, 2022 14:02
alexgrozav
alexgrozav approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works as expected. Nice work! :)

@ivov ivov merged commit b1e7152 into master Aug 22, 2022
@ivov ivov deleted the n8n-4298-support-paired-item-on-pinned-data-fe branch August 22, 2022 15:46
@janober janober added the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
@janober
Copy link
Member

janober commented Aug 24, 2022

Got released with n8n@0.192.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
@saurabharch saurabharch mentioned this pull request Feb 11, 2024
Closed
@reconsumeralization reconsumeralization mentioned this pull request Feb 11, 2024
Open
@johnperez416 johnperez416 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @alexgrozav