Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nodes-base): Apply lint rule node-param-display-name-not-first-position #4073

Merged
merged 2 commits into from
Sep 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,7 @@ module.exports = {
'n8n-nodes-base/node-param-description-wrong-for-simplify': 'error',
'n8n-nodes-base/node-param-description-wrong-for-upsert': 'error',
'n8n-nodes-base/node-param-display-name-excess-inner-whitespace': 'error',
'n8n-nodes-base/node-param-display-name-not-first-position': 'error',
'n8n-nodes-base/node-param-display-name-miscased': 'error',
'n8n-nodes-base/node-param-display-name-miscased-id': 'error',
'n8n-nodes-base/node-param-display-name-untrimmed': 'error',
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/PostBin/BinDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ export const binOperations: INodeProperties[] = [
// Properties of the `Bin` resource
export const binFields: INodeProperties[] = [
{
name: 'binId',
displayName: 'Bin ID',
name: 'binId',
type: 'string',
default: '',
required: true,
Expand Down
6 changes: 3 additions & 3 deletions packages/nodes-base/nodes/PostBin/RequestDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ export const requestOperations: INodeProperties[] = [
// Properties of the `Request` resource
export const requestFields: INodeProperties[] = [
{
name: 'binId',
displayName: 'Bin ID',
name: 'binId',
type: 'string',
default: '',
required: true,
Expand All @@ -100,8 +100,8 @@ export const requestFields: INodeProperties[] = [
description: 'Unique identifier for each bin',
},
{
name: 'binContent',
displayName: 'Bin Content',
name: 'binContent',
type: 'string',
default: '',
typeOptions: {
Expand All @@ -122,8 +122,8 @@ export const requestFields: INodeProperties[] = [
},
},
{
name: 'requestId',
displayName: 'Request ID',
name: 'requestId',
type: 'string',
default: '',
required: true,
Expand Down
10 changes: 5 additions & 5 deletions packages/nodes-base/nodes/SendInBlue/EmailDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ const sendHtmlEmailFields: INodeProperties[] = [
displayName: 'Attachment Data',
values: [
{
default: '',
displayName: 'Input Data Field Name',
default: '',
name: 'binaryPropertyName',
type: 'string',
description:
Expand All @@ -196,8 +196,8 @@ const sendHtmlEmailFields: INodeProperties[] = [
displayName: 'Receipient',
values: [
{
name: 'bcc',
displayName: 'Receipient',
name: 'bcc',
type: 'string',
default: '',
},
Expand All @@ -222,8 +222,8 @@ const sendHtmlEmailFields: INodeProperties[] = [
displayName: 'Receipient',
values: [
{
name: 'cc',
displayName: 'Receipient',
name: 'cc',
type: 'string',
default: '',
},
Expand All @@ -249,8 +249,8 @@ const sendHtmlEmailFields: INodeProperties[] = [
name: 'tags',
values: [
{
default: '',
displayName: 'Tag',
default: '',
name: 'tag',
type: 'string',
},
Expand Down Expand Up @@ -398,8 +398,8 @@ const sendHtmlTemplateEmailFields: INodeProperties[] = [
name: 'tags',
values: [
{
default: '',
displayName: 'Tag',
default: '',
name: 'tag',
type: 'string',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export class SendInBlueTrigger implements INodeType {
],
properties: [
{
default: 'transactional',
displayName: 'Resource',
default: 'transactional',
name: 'type',
options: [
{ name: 'Inbound', value: 'inbound' },
Expand Down
16 changes: 8 additions & 8 deletions packages/nodes-base/nodes/Spotify/Spotify.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -377,26 +377,26 @@ export class Spotify implements INodeType {
description: 'Get a playlist by URI or ID',
action: 'Get a playlist',
},
{
name: "Get the User's Playlists",
value: 'getUserPlaylists',
description: "Get a user's playlists",
action: "Get a user's playlists",
},
{
name: 'Get Tracks',
value: 'getTracks',
description: "Get a playlist's tracks by URI or ID",
action: "Get a playlist's tracks by URI or ID",
},
{
name: `Get the User's Playlists`,
value: 'getUserPlaylists',
description: "Get a user's playlists",
action: "Get a user's playlists",
},
{
name: 'Remove an Item',
value: 'delete',
description: 'Remove tracks from a playlist by track and playlist URI or ID',
action: 'Remove an item from a playlist',
},
{
name: `Search`,
name: 'Search',
value: 'search',
description: 'Search playlists by keyword',
action: 'Search playlists by keyword',
Expand Down Expand Up @@ -1322,4 +1322,4 @@ export class Spotify implements INodeType {

return this.prepareOutputData(returnData);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -518,8 +518,8 @@ export const observableFields: INodeProperties[] = [
default: false,
},
{
name: 'Status',
displayName: 'Status',
name: 'Status',
type: 'options',
default: '',
options: [
Expand Down